Skip to content

Commit 13d9c6b

Browse files
committed
ALSA: hda/realtek: Workaround for conflicting SSID on ASUS ROG Strix G17
ASUS ROG Strix G17 has the very same PCI and codec SSID (1043:103f) as ASUS TX300, and unfortunately, the existing quirk for TX300 is broken on ASUS ROG. Actually the device works without the quirk, so we'll need to clear the quirk before applying for this device. Since ASUS ROG has a different codec (ALC294 - while TX300 has ALC282), this patch adds a workaround for the device, just clearing the codec->fixup_id by checking the codec vendor_id. It's a bit ugly to add such a workaround there, but it seems to be the simplest way. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=214101 Cc: <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 65ca89c commit 13d9c6b

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

sound/pci/hda/patch_realtek.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9521,6 +9521,16 @@ static int patch_alc269(struct hda_codec *codec)
95219521

95229522
snd_hda_pick_fixup(codec, alc269_fixup_models,
95239523
alc269_fixup_tbl, alc269_fixups);
9524+
/* FIXME: both TX300 and ROG Strix G17 have the same SSID, and
9525+
* the quirk breaks the latter (bko#214101).
9526+
* Clear the wrong entry.
9527+
*/
9528+
if (codec->fixup_id == ALC282_FIXUP_ASUS_TX300 &&
9529+
codec->core.vendor_id == 0x10ec0294) {
9530+
codec_dbg(codec, "Clear wrong fixup for ASUS ROG Strix G17\n");
9531+
codec->fixup_id = HDA_FIXUP_ID_NOT_SET;
9532+
}
9533+
95249534
snd_hda_pick_pin_fixup(codec, alc269_pin_fixup_tbl, alc269_fixups, true);
95259535
snd_hda_pick_pin_fixup(codec, alc269_fallback_pin_fixup_tbl, alc269_fixups, false);
95269536
snd_hda_pick_fixup(codec, NULL, alc269_fixup_vendor_tbl,

0 commit comments

Comments
 (0)