ipmi_si: Drop redundant check before calling put_device()

andy-shev · cminyard · commit 25f314db2eff · 2021-04-02T12:53:39.000-05:00
put_device() is NULL aware, drop redundant check before calling it.

Signed-off-by: Andy Shevchenko &lt;andriy.shevchenko@linux.intel.com&gt;
Message-Id: &lt;20210402174334.13466-10-andriy.shevchenko@linux.intel.com&gt;
Signed-off-by: Corey Minyard &lt;cminyard@mvista.com&gt;
diff --git a/drivers/char/ipmi/ipmi_si_hotmod.c b/drivers/char/ipmi/ipmi_si_hotmod.c
@@ -223,8 +223,7 @@ static int hotmod_handler(const char *val, const struct kernel_param *kp)
 				if (strcmp(pdev->name, "hotmod-ipmi-si") == 0)
 					platform_device_unregister(pdev);
 			}
-			if (dev)
-				put_device(dev);
+			put_device(dev);
 		}
 	}
 	rv = strlen(val);

Original file line number	Diff line number	Diff line change
`@@ -223,8 +223,7 @@ static int hotmod_handler(const char val, const struct kernel_param kp)`
`223`	`223`	`if (strcmp(pdev->name, "hotmod-ipmi-si") == 0)`
`224`	`224`	`platform_device_unregister(pdev);`
`225`	`225`	`}`
`226`		`- if (dev)`
`227`		`- put_device(dev);`
	`226`	`+ put_device(dev);`
`228`	`227`	`}`
`229`	`228`	`}`
`230`	`229`	`rv = strlen(val);`