Skip to content

Commit 266fd99

Browse files
enooltiwai
authored andcommitted
ALSA: hda/realtek: ALC285 Thinkpad jack pin quirk is unreachable
In 9bbb94e ("ALSA: hda/realtek: fix static noise on ALC285 Lenovo laptops") an existing Lenovo quirk was made more generic by removing a 0x12 pin requirement from the entry. This made the second chance table Thinkpad jack entry unreachable as the pin configurations became identical. Revert the 0x12 pin requirement removal and move Thinkpad jack pin quirk back to the primary pin table as they can co-exist when more specific configurations come first. Add a more targeted pin quirk for Lenovo devices that have 0x12 as 0x40000000. Tested on Yoga 6 (AMD) laptop. [ Corrected the commit ID -- tiwai ] Fixes: 9bbb94e ("ALSA: hda/realtek: fix static noise on ALC285 Lenovo laptops") Signed-off-by: Sami Loone <[email protected]> Cc: <[email protected]> Link: https://lore.kernel.org/r/YI0oefvTYn8URYDb@yoga Signed-off-by: Takashi Iwai <[email protected]>
1 parent 2e6a731 commit 266fd99

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

sound/pci/hda/patch_realtek.c

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8801,6 +8801,16 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
88018801
{0x19, 0x03a11020},
88028802
{0x21, 0x0321101f}),
88038803
SND_HDA_PIN_QUIRK(0x10ec0285, 0x17aa, "Lenovo", ALC285_FIXUP_LENOVO_PC_BEEP_IN_NOISE,
8804+
{0x12, 0x90a60130},
8805+
{0x14, 0x90170110},
8806+
{0x19, 0x04a11040},
8807+
{0x21, 0x04211020}),
8808+
SND_HDA_PIN_QUIRK(0x10ec0285, 0x17aa, "Lenovo", ALC285_FIXUP_LENOVO_PC_BEEP_IN_NOISE,
8809+
{0x14, 0x90170110},
8810+
{0x19, 0x04a11040},
8811+
{0x1d, 0x40600001},
8812+
{0x21, 0x04211020}),
8813+
SND_HDA_PIN_QUIRK(0x10ec0285, 0x17aa, "Lenovo", ALC285_FIXUP_THINKPAD_NO_BASS_SPK_HEADSET_JACK,
88048814
{0x14, 0x90170110},
88058815
{0x19, 0x04a11040},
88068816
{0x21, 0x04211020}),
@@ -8971,10 +8981,6 @@ static const struct snd_hda_pin_quirk alc269_fallback_pin_fixup_tbl[] = {
89718981
SND_HDA_PIN_QUIRK(0x10ec0274, 0x1028, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB,
89728982
{0x19, 0x40000000},
89738983
{0x1a, 0x40000000}),
8974-
SND_HDA_PIN_QUIRK(0x10ec0285, 0x17aa, "Lenovo", ALC285_FIXUP_THINKPAD_NO_BASS_SPK_HEADSET_JACK,
8975-
{0x14, 0x90170110},
8976-
{0x19, 0x04a11040},
8977-
{0x21, 0x04211020}),
89788984
{}
89798985
};
89808986

0 commit comments

Comments
 (0)