Skip to content

Commit 28bba1e

Browse files
Zhen LeiLorenzo Pieralisi
authored andcommitted
PCI: mediatek: Remove redundant error printing in mtk_pcie_subsys_powerup()
When devm_ioremap_resource() fails, a clear enough error message will be printed by its subfunction __devm_ioremap_resource(). The error information contains the device name, failure cause, and possibly resource information. Therefore, remove the error printing here to simplify code and reduce the binary size. Link: https://lore.kernel.org/r/[email protected] Reported-by: Hulk Robot <[email protected]> Signed-off-by: Zhen Lei <[email protected]> Signed-off-by: Lorenzo Pieralisi <[email protected]> Reviewed-by: Krzysztof Wilczyński <[email protected]>
1 parent 6efb943 commit 28bba1e

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/pci/controller/pcie-mediatek.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -991,10 +991,8 @@ static int mtk_pcie_subsys_powerup(struct mtk_pcie *pcie)
991991
regs = platform_get_resource_byname(pdev, IORESOURCE_MEM, "subsys");
992992
if (regs) {
993993
pcie->base = devm_ioremap_resource(dev, regs);
994-
if (IS_ERR(pcie->base)) {
995-
dev_err(dev, "failed to map shared register\n");
994+
if (IS_ERR(pcie->base))
996995
return PTR_ERR(pcie->base);
997-
}
998996
}
999997

1000998
pcie->free_ck = devm_clk_get(dev, "free_ck");

0 commit comments

Comments
 (0)