Skip to content

Commit 294c34e

Browse files
andy-shevrafaeljw
authored andcommitted
media: ipu3-cio2: Drop reference on error path in cio2_bridge_connect_sensor()
The commit 71f6428 ("ACPI: utils: Fix reference counting in for_each_acpi_dev_match()") moved adev assignment outside of error path and hence made acpi_dev_put(sensor->adev) a no-op. We still need to drop reference count on error path, and to achieve that, replace sensor->adev by locally assigned adev. Fixes: 71f6428 ("ACPI: utils: Fix reference counting in for_each_acpi_dev_match()") Depends-on: fc68f42 ("ACPI: fix NULL pointer dereference") Reported-by: Jens Axboe <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Acked-by: Sakari Ailus <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent e22ce8e commit 294c34e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/media/pci/intel/ipu3/cio2-bridge.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg,
226226
err_free_swnodes:
227227
software_node_unregister_nodes(sensor->swnodes);
228228
err_put_adev:
229-
acpi_dev_put(sensor->adev);
229+
acpi_dev_put(adev);
230230
return ret;
231231
}
232232

0 commit comments

Comments
 (0)