Skip to content

Commit 29c8f40

Browse files
ujfalusitiwai
authored andcommitted
ALSA: hda/realtek: Chain in pop reduction fixup for ThinkStation P340
Lenovo ThinkStation P340 uses ALC623 codec (SSID 17aa:1048) and it produces bug plock/pop noise over line out (green jack on the back) which can be fixed by applying ALC269_FIXUP_NO_SHUTUP tot he machine. Convert the existing entry for the same SSID to chain to apply this fixup as well. Suggested-by: Takashi Iwai <[email protected]> Signed-off-by: Peter Ujfalusi <[email protected]> Cc: <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent dad19af commit 29c8f40

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

sound/pci/hda/patch_realtek.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6567,6 +6567,7 @@ enum {
65676567
ALC295_FIXUP_HP_OMEN,
65686568
ALC285_FIXUP_HP_SPECTRE_X360,
65696569
ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP,
6570+
ALC623_FIXUP_LENOVO_THINKSTATION_P340,
65706571
};
65716572

65726573
static const struct hda_fixup alc269_fixups[] = {
@@ -8139,6 +8140,12 @@ static const struct hda_fixup alc269_fixups[] = {
81398140
.chained = true,
81408141
.chain_id = ALC285_FIXUP_THINKPAD_HEADSET_JACK,
81418142
},
8143+
[ALC623_FIXUP_LENOVO_THINKSTATION_P340] = {
8144+
.type = HDA_FIXUP_FUNC,
8145+
.v.func = alc_fixup_no_shutup,
8146+
.chained = true,
8147+
.chain_id = ALC283_FIXUP_HEADSET_MIC,
8148+
},
81428149
};
81438150

81448151
static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -8457,7 +8464,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
84578464
SND_PCI_QUIRK(0x1558, 0xc019, "Clevo NH77D[BE]Q", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
84588465
SND_PCI_QUIRK(0x1558, 0xc022, "Clevo NH77[DC][QW]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
84598466
SND_PCI_QUIRK(0x17aa, 0x1036, "Lenovo P520", ALC233_FIXUP_LENOVO_MULTI_CODECS),
8460-
SND_PCI_QUIRK(0x17aa, 0x1048, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
8467+
SND_PCI_QUIRK(0x17aa, 0x1048, "ThinkCentre Station", ALC623_FIXUP_LENOVO_THINKSTATION_P340),
84618468
SND_PCI_QUIRK(0x17aa, 0x20f2, "Thinkpad SL410/510", ALC269_FIXUP_SKU_IGNORE),
84628469
SND_PCI_QUIRK(0x17aa, 0x215e, "Thinkpad L512", ALC269_FIXUP_SKU_IGNORE),
84638470
SND_PCI_QUIRK(0x17aa, 0x21b8, "Thinkpad Edge 14", ALC269_FIXUP_SKU_IGNORE),
@@ -8724,6 +8731,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
87248731
{.id = ALC295_FIXUP_HP_OMEN, .name = "alc295-hp-omen"},
87258732
{.id = ALC285_FIXUP_HP_SPECTRE_X360, .name = "alc285-hp-spectre-x360"},
87268733
{.id = ALC287_FIXUP_IDEAPAD_BASS_SPK_AMP, .name = "alc287-ideapad-bass-spk-amp"},
8734+
{.id = ALC623_FIXUP_LENOVO_THINKSTATION_P340, .name = "alc623-lenovo-thinkstation-p340"},
87278735
{}
87288736
};
87298737
#define ALC225_STANDARD_PINS \

0 commit comments

Comments
 (0)