ALSA: usb-audio: scarlett2: snd_scarlett_gen2_controls_create() can be static

intel-lab-lkp · tiwai · commit 2b899f31f1a6 · 2021-05-23T10:31:49.000+02:00
sound/usb/mixer_scarlett_gen2.c:2000:5: warning: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static? Fixes: 265d1a9 ("ALSA: usb-audio: scarlett2: Improve driver startup messages") Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/r/20210522180900.GA83915@f59a3af2f1d9 Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen2.c
@@ -1997,8 +1997,8 @@ static int scarlett2_mixer_status_create(struct usb_mixer_interface *mixer)
 	return usb_submit_urb(mixer->urb, GFP_KERNEL);
 }
 
-int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer,
-				      const struct scarlett2_device_info *info)
+static int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer,
+					     const struct scarlett2_device_info *info)
 {
 	int err;
 

Original file line number	Diff line number	Diff line change
`@@ -1997,8 +1997,8 @@ static int scarlett2_mixer_status_create(struct usb_mixer_interface *mixer)`
`1997`	`1997`	`return usb_submit_urb(mixer->urb, GFP_KERNEL);`
`1998`	`1998`	`}`
`1999`	`1999`
`2000`		`-int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer,`
`2001`		`- const struct scarlett2_device_info *info)`
	`2000`	`+static int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer,`
	`2001`	`+ const struct scarlett2_device_info *info)`
`2002`	`2002`	`{`
`2003`	`2003`	`int err;`
`2004`	`2004`