Skip to content

Commit 2e496ac

Browse files
mwajdeczdanvet
authored andcommitted
drm/i915/guc: Stop using mutex while sending CTB messages
We are no longer using descriptor to hold G2H replies and we are protecting access to the descriptor and command buffer by the separate spinlock, so we can stop using mutex. Signed-off-by: Michal Wajdeczko <[email protected]> Signed-off-by: Matthew Brost <[email protected]> Reviewed-by: Matthew Brost <[email protected]> Signed-off-by: Daniel Vetter <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent d35ca60 commit 2e496ac

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,6 @@ static int ct_send(struct intel_guc_ct *ct,
559559
int intel_guc_ct_send(struct intel_guc_ct *ct, const u32 *action, u32 len,
560560
u32 *response_buf, u32 response_buf_size)
561561
{
562-
struct intel_guc *guc = ct_to_guc(ct);
563562
u32 status = ~0; /* undefined */
564563
int ret;
565564

@@ -568,8 +567,6 @@ int intel_guc_ct_send(struct intel_guc_ct *ct, const u32 *action, u32 len,
568567
return -ENODEV;
569568
}
570569

571-
mutex_lock(&guc->send_mutex);
572-
573570
ret = ct_send(ct, action, len, response_buf, response_buf_size, &status);
574571
if (unlikely(ret < 0)) {
575572
CT_ERROR(ct, "Sending action %#x failed (err=%d status=%#X)\n",
@@ -579,7 +576,6 @@ int intel_guc_ct_send(struct intel_guc_ct *ct, const u32 *action, u32 len,
579576
action[0], ret, ret);
580577
}
581578

582-
mutex_unlock(&guc->send_mutex);
583579
return ret;
584580
}
585581

0 commit comments

Comments
 (0)