Skip to content

Commit 2e5848a

Browse files
lztogregkh
authored andcommitted
staging: comedi: cb_pcidas: fix request_irq() warn
request_irq() wont accept a name which contains slash so we need to repalce it with something else -- otherwise it will trigger a warning and the entry in /proc/irq/ will not be created since the .name might be used by userspace and we don't want to break userspace, so we are changing the parameters passed to request_irq() [ 1.630764] name 'pci-das1602/16' [ 1.630950] WARNING: CPU: 0 PID: 181 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0 [ 1.634009] RIP: 0010:__xlate_proc_name+0x93/0xb0 [ 1.639441] Call Trace: [ 1.639976] proc_mkdir+0x18/0x20 [ 1.641946] request_threaded_irq+0xfe/0x160 [ 1.642186] cb_pcidas_auto_attach+0xf4/0x610 [cb_pcidas] Suggested-by: Ian Abbott <[email protected]> Reviewed-by: Ian Abbott <[email protected]> Signed-off-by: Tong Zhang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent e06da9e commit 2e5848a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/staging/comedi/drivers/cb_pcidas.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1281,7 +1281,7 @@ static int cb_pcidas_auto_attach(struct comedi_device *dev,
12811281
devpriv->amcc + AMCC_OP_REG_INTCSR);
12821282

12831283
ret = request_irq(pcidev->irq, cb_pcidas_interrupt, IRQF_SHARED,
1284-
dev->board_name, dev);
1284+
"cb_pcidas", dev);
12851285
if (ret) {
12861286
dev_dbg(dev->class_dev, "unable to allocate irq %d\n",
12871287
pcidev->irq);

0 commit comments

Comments
 (0)