Skip to content

Commit 2f7484f

Browse files
vneethvhcahca
authored andcommitted
s390/cio: remove invalid condition on IO_SCH_UNREG
The condition to check the cdev pointer validity on css_sch_device_unregister() is a leftover from the 'commit 8cc0dcf ("s390/cio: remove pm support from ccw bus driver")'. This could lead to a situation, where detaching the device is not happening completely. Remove this invalid condition in the IO_SCH_UNREG case. Link: https://lore.kernel.org/r/[email protected] Fixes: 8cc0dcf ("s390/cio: remove pm support from ccw bus driver") Reported-by: Christian Ehrhardt <[email protected]> Suggested-by: Christian Ehrhardt <[email protected]> Cc: <[email protected]> Signed-off-by: Vineeth Vijayan <[email protected]> Tested-by: Julian Wiedmann <[email protected]> Reviewed-by: Peter Oberparleiter <[email protected]> Tested-by: Christian Ehrhardt <[email protected]> Signed-off-by: Heiko Carstens <[email protected]>
1 parent b0583ab commit 2f7484f

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/s390/cio/device.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1532,8 +1532,7 @@ static int io_subchannel_sch_event(struct subchannel *sch, int process)
15321532
switch (action) {
15331533
case IO_SCH_ORPH_UNREG:
15341534
case IO_SCH_UNREG:
1535-
if (!cdev)
1536-
css_sch_device_unregister(sch);
1535+
css_sch_device_unregister(sch);
15371536
break;
15381537
case IO_SCH_ORPH_ATTACH:
15391538
case IO_SCH_UNREG_ATTACH:

0 commit comments

Comments
 (0)