Skip to content

Commit 2f9f21c

Browse files
lpstankusshuahkh
authored andcommitted
kunit: Match parenthesis alignment to improve code readability
Tidy up code by fixing the following checkpatch warnings: CHECK: Alignment should match open parenthesis CHECK: Lines should not end with a '(' Signed-off-by: Lucas Stankus <[email protected]> Reviewed-by: Brendan Higgins <[email protected]> Signed-off-by: Shuah Khan <[email protected]>
1 parent a38fd87 commit 2f9f21c

File tree

1 file changed

+20
-11
lines changed

1 file changed

+20
-11
lines changed

lib/kunit/assert.c

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ void kunit_base_assert_format(const struct kunit_assert *assert,
2525
}
2626

2727
string_stream_add(stream, "%s FAILED at %s:%d\n",
28-
expect_or_assert, assert->file, assert->line);
28+
expect_or_assert, assert->file, assert->line);
2929
}
3030
EXPORT_SYMBOL_GPL(kunit_base_assert_format);
3131

@@ -48,8 +48,9 @@ EXPORT_SYMBOL_GPL(kunit_fail_assert_format);
4848
void kunit_unary_assert_format(const struct kunit_assert *assert,
4949
struct string_stream *stream)
5050
{
51-
struct kunit_unary_assert *unary_assert = container_of(
52-
assert, struct kunit_unary_assert, assert);
51+
struct kunit_unary_assert *unary_assert;
52+
53+
unary_assert = container_of(assert, struct kunit_unary_assert, assert);
5354

5455
kunit_base_assert_format(assert, stream);
5556
if (unary_assert->expected_true)
@@ -67,8 +68,10 @@ EXPORT_SYMBOL_GPL(kunit_unary_assert_format);
6768
void kunit_ptr_not_err_assert_format(const struct kunit_assert *assert,
6869
struct string_stream *stream)
6970
{
70-
struct kunit_ptr_not_err_assert *ptr_assert = container_of(
71-
assert, struct kunit_ptr_not_err_assert, assert);
71+
struct kunit_ptr_not_err_assert *ptr_assert;
72+
73+
ptr_assert = container_of(assert, struct kunit_ptr_not_err_assert,
74+
assert);
7275

7376
kunit_base_assert_format(assert, stream);
7477
if (!ptr_assert->value) {
@@ -111,8 +114,10 @@ static bool is_literal(struct kunit *test, const char *text, long long value,
111114
void kunit_binary_assert_format(const struct kunit_assert *assert,
112115
struct string_stream *stream)
113116
{
114-
struct kunit_binary_assert *binary_assert = container_of(
115-
assert, struct kunit_binary_assert, assert);
117+
struct kunit_binary_assert *binary_assert;
118+
119+
binary_assert = container_of(assert, struct kunit_binary_assert,
120+
assert);
116121

117122
kunit_base_assert_format(assert, stream);
118123
string_stream_add(stream,
@@ -137,8 +142,10 @@ EXPORT_SYMBOL_GPL(kunit_binary_assert_format);
137142
void kunit_binary_ptr_assert_format(const struct kunit_assert *assert,
138143
struct string_stream *stream)
139144
{
140-
struct kunit_binary_ptr_assert *binary_assert = container_of(
141-
assert, struct kunit_binary_ptr_assert, assert);
145+
struct kunit_binary_ptr_assert *binary_assert;
146+
147+
binary_assert = container_of(assert, struct kunit_binary_ptr_assert,
148+
assert);
142149

143150
kunit_base_assert_format(assert, stream);
144151
string_stream_add(stream,
@@ -159,8 +166,10 @@ EXPORT_SYMBOL_GPL(kunit_binary_ptr_assert_format);
159166
void kunit_binary_str_assert_format(const struct kunit_assert *assert,
160167
struct string_stream *stream)
161168
{
162-
struct kunit_binary_str_assert *binary_assert = container_of(
163-
assert, struct kunit_binary_str_assert, assert);
169+
struct kunit_binary_str_assert *binary_assert;
170+
171+
binary_assert = container_of(assert, struct kunit_binary_str_assert,
172+
assert);
164173

165174
kunit_base_assert_format(assert, stream);
166175
string_stream_add(stream,

0 commit comments

Comments
 (0)