Skip to content

Commit 313bf28

Browse files
alim-akhtarmartinkpetersen
authored andcommitted
scsi: ufs: ufs-exynos: Fix static checker warning
clk_get_rate() returns unsigned long and currently this driver stores the return value in u32 type, resulting the below warning: Fixed smatch warnings: drivers/scsi/ufs/ufs-exynos.c:286 exynos_ufs_get_clk_info() warn: wrong type for 'ufs->mclk_rate' (should be 'ulong') drivers/scsi/ufs/ufs-exynos.c:287 exynos_ufs_get_clk_info() warn: wrong type for 'pclk_rate' (should be 'ulong') Link: https://lore.kernel.org/r/[email protected] Fixes: 55f4b1f ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos SoCs") Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Alim Akhtar <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent b3e2c72 commit 313bf28

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

drivers/scsi/ufs/ufs-exynos.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ static int exynos_ufs_get_clk_info(struct exynos_ufs *ufs)
260260
struct ufs_hba *hba = ufs->hba;
261261
struct list_head *head = &hba->clk_list_head;
262262
struct ufs_clk_info *clki;
263-
u32 pclk_rate;
263+
unsigned long pclk_rate;
264264
u32 f_min, f_max;
265265
u8 div = 0;
266266
int ret = 0;
@@ -299,7 +299,7 @@ static int exynos_ufs_get_clk_info(struct exynos_ufs *ufs)
299299
}
300300

301301
if (unlikely(pclk_rate < f_min || pclk_rate > f_max)) {
302-
dev_err(hba->dev, "not available pclk range %d\n", pclk_rate);
302+
dev_err(hba->dev, "not available pclk range %lu\n", pclk_rate);
303303
ret = -EINVAL;
304304
goto out;
305305
}

drivers/scsi/ufs/ufs-exynos.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ struct exynos_ufs {
184184
u32 pclk_div;
185185
u32 pclk_avail_min;
186186
u32 pclk_avail_max;
187-
u32 mclk_rate;
187+
unsigned long mclk_rate;
188188
int avail_ln_rx;
189189
int avail_ln_tx;
190190
int rx_sel_idx;

0 commit comments

Comments
 (0)