Skip to content

Commit 335ffab

Browse files
osctobevireshk
authored andcommitted
opp: remove WARN when no valid OPPs remain
This WARN can be triggered per-core and the stack trace is not useful. Replace it with plain dev_err(). Fix a comment while at it. Signed-off-by: Michał Mirosław <[email protected]> Signed-off-by: Viresh Kumar <[email protected]>
1 parent e73f0f0 commit 335ffab

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/opp/of.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -964,8 +964,9 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table)
964964
}
965965
}
966966

967-
/* There should be one of more OPP defined */
968-
if (WARN_ON(!count)) {
967+
/* There should be one or more OPPs defined */
968+
if (!count) {
969+
dev_err(dev, "%s: no supported OPPs", __func__);
969970
ret = -ENOENT;
970971
goto remove_static_opp;
971972
}

0 commit comments

Comments
 (0)