Skip to content

Commit 34b07d4

Browse files
nathanchancerodrigovivi
authored andcommitted
drm/i915: Enable -Wuninitialized
-Wunintialized was disabled in commit c562746 ("drm/i915: Disable -Wuninitialized") because there were two warnings that were false positives. The first was due to DECLARE_WAIT_QUEUE_HEAD_ONSTACK, which was fixed in LLVM 9.0.0. The second was in busywait_stop, which was fixed in LLVM 10.0.0 (issue 415). The kernel's minimum version for LLVM is 10.0.1 so this warning can be safely enabled, where it has already caught a couple bugs. Link: ClangBuiltLinux#220 Link: ClangBuiltLinux#415 Link: ClangBuiltLinux#499 Link: llvm/llvm-project@2e04039 Link: llvm/llvm-project@c667cdc Fixes: c562746 ("drm/i915: Disable -Wuninitialized") References: 2ea4a7b ("drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show") References: 2034c21 ("drm/i915/display: Ensure that ret is always initialized in icl_combo_phy_verify_state") Reported-by: Arnd Bergmann <[email protected]> Signed-off-by: Nathan Chancellor <[email protected]> Reviewed-by: Chris Wilson <[email protected]> Signed-off-by: Chris Wilson <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit b242318) Signed-off-by: Rodrigo Vivi <[email protected]>
1 parent 58b779d commit 34b07d4

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/gpu/drm/i915/Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
2121
subdir-ccflags-y += $(call cc-disable-warning, sign-compare)
2222
subdir-ccflags-y += $(call cc-disable-warning, sometimes-uninitialized)
2323
subdir-ccflags-y += $(call cc-disable-warning, initializer-overrides)
24-
subdir-ccflags-y += $(call cc-disable-warning, uninitialized)
2524
subdir-ccflags-y += $(call cc-disable-warning, frame-address)
2625
subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
2726

0 commit comments

Comments
 (0)