Skip to content

Commit 3a06b91

Browse files
jwrdegoedesre
authored andcommitted
power: supply: axp288_fuel_gauge: Make "T3 MRD" no_battery_list DMI entry more generic
It turns out that the "T3 MRD" DMI_BOARD_NAME value is used in a lot of different Cherry Trail x5-z8300 / x5-z8350 based Mini-PC / HDMI-stick models from Ace PC / Meegopad / MinisForum / Wintel (and likely also other vendors). Most of the other DMI strings on these boxes unfortunately contain various generic values like "Default string" or "$(DEFAULT_STRING)", so we cannot match on them. These devices do have their chassis-type correctly set to a value of "3" (desktop) which is a pleasant surprise, so also match on that. This should avoid the quirk accidentally also getting applied to laptops / tablets (which do actually have a battery). Although in my quite large database of Bay and Cherry Trail based devices DMIdecode dumps I don't have any laptops / tables with a board-name of "T3 MRD", so this should not be an issue. BugLink: https://askubuntu.com/questions/1206714/how-can-a-mini-pc-be-stopped-from-being-detected-as-a-laptop-with-a-battery/ Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Sebastian Reichel <[email protected]>
1 parent 0973e96 commit 3a06b91

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

drivers/power/supply/axp288_fuel_gauge.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -723,15 +723,6 @@ static const struct dmi_system_id axp288_no_battery_list[] = {
723723
DMI_MATCH(DMI_PRODUCT_NAME, "MEEGOPAD T02"),
724724
},
725725
},
726-
{
727-
/* Meegopad T08 */
728-
.matches = {
729-
DMI_MATCH(DMI_SYS_VENDOR, "Default string"),
730-
DMI_MATCH(DMI_BOARD_VENDOR, "To be filled by OEM."),
731-
DMI_MATCH(DMI_BOARD_NAME, "T3 MRD"),
732-
DMI_MATCH(DMI_BOARD_VERSION, "V1.1"),
733-
},
734-
},
735726
{ /* Mele PCG03 Mini PC */
736727
.matches = {
737728
DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Mini PC"),
@@ -745,6 +736,15 @@ static const struct dmi_system_id axp288_no_battery_list[] = {
745736
DMI_MATCH(DMI_PRODUCT_NAME, "Z83-4"),
746737
}
747738
},
739+
{
740+
/* Various Ace PC/Meegopad/MinisForum/Wintel Mini-PCs/HDMI-sticks */
741+
.matches = {
742+
DMI_MATCH(DMI_BOARD_NAME, "T3 MRD"),
743+
DMI_MATCH(DMI_CHASSIS_TYPE, "3"),
744+
DMI_MATCH(DMI_BIOS_VENDOR, "American Megatrends Inc."),
745+
DMI_MATCH(DMI_BIOS_VERSION, "5.11"),
746+
},
747+
},
748748
{}
749749
};
750750

0 commit comments

Comments
 (0)