Skip to content

Commit 3b8b571

Browse files
Uwe Kleine-Königthierryreding
authored andcommitted
pwm: tegra: Don't needlessly enable and disable the clock in .remove()
There is no reason to enable the PWM clock just to assert the reset control. (If the reset control depends on the clock this is a bug and probably it doesn't because in .probe() the reset is deasserted without the clock being enabled.) Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Thierry Reding <[email protected]>
1 parent 86f7fa7 commit 3b8b571

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/pwm/pwm-tegra.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -300,14 +300,8 @@ static int tegra_pwm_probe(struct platform_device *pdev)
300300
static int tegra_pwm_remove(struct platform_device *pdev)
301301
{
302302
struct tegra_pwm_chip *pc = platform_get_drvdata(pdev);
303-
int err;
304-
305-
err = clk_prepare_enable(pc->clk);
306-
if (err < 0)
307-
return err;
308303

309304
reset_control_assert(pc->rst);
310-
clk_disable_unprepare(pc->clk);
311305

312306
return pwmchip_remove(&pc->chip);
313307
}

0 commit comments

Comments
 (0)