Skip to content

Commit 3dfa159

Browse files
tititiou36mmind
authored andcommitted
drm/rockchip: lvds: Fix an error handling path
'ret' is know to be 0 a this point. Checking the return value of 'phy_init()' and 'phy_set_mode()' was intended instead. So add the missing assignments. Fixes: cca1705 ("drm/rockchip: lvds: Add PX30 support") Signed-off-by: Christophe JAILLET <[email protected]> Signed-off-by: Heiko Stuebner <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/248220d4815dc8c8088cebfab7d6df5f70518438.1619881852.git.christophe.jaillet@wanadoo.fr
1 parent 7455ced commit 3dfa159

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/rockchip/rockchip_lvds.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -499,11 +499,11 @@ static int px30_lvds_probe(struct platform_device *pdev,
499499
if (IS_ERR(lvds->dphy))
500500
return PTR_ERR(lvds->dphy);
501501

502-
phy_init(lvds->dphy);
502+
ret = phy_init(lvds->dphy);
503503
if (ret)
504504
return ret;
505505

506-
phy_set_mode(lvds->dphy, PHY_MODE_LVDS);
506+
ret = phy_set_mode(lvds->dphy, PHY_MODE_LVDS);
507507
if (ret)
508508
return ret;
509509

0 commit comments

Comments
 (0)