Skip to content

Commit 3f8518b

Browse files
vstempenalexdeucher
authored andcommitted
drm/amd/display: Release MST resources on switch from MST to SST
[why] When OS overrides training link training parameters for MST device to SST mode, MST resources are not released and leak of the resource may result crash and incorrect MST discovery during following hot plugs. [how] Retaining sink object to be reused by SST link and releasing MST resources. Signed-off-by: Vladimir Stempen <[email protected]> Reviewed-by: Wenjing Liu <[email protected]> Acked-by: Stylon Wang <[email protected]> Tested-by: Daniel Wheeler <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 74b4afa commit 3f8518b

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1917,6 +1917,8 @@ static void set_dp_mst_mode(struct dc_link *link, bool mst_enable)
19171917
link->type = dc_connection_single;
19181918
link->local_sink = link->remote_sinks[0];
19191919
link->local_sink->sink_signal = SIGNAL_TYPE_DISPLAY_PORT;
1920+
dc_sink_retain(link->local_sink);
1921+
dm_helpers_dp_mst_stop_top_mgr(link->ctx, link);
19201922
} else if (mst_enable == true &&
19211923
link->type == dc_connection_single &&
19221924
link->remote_sinks[0] != NULL) {

0 commit comments

Comments
 (0)