Skip to content

Commit 4168a8d

Browse files
josephhzaxboe
authored andcommitted
block/bfq: update comments and default value in docs for fifo_expire
Correct the comments since bfq_fifo_expire[0] is for async request, while bfq_fifo_expire[1] is for sync request. Also update docs, according the source code, the default fifo_expire_async is 250ms, and fifo_expire_sync is 125ms. Signed-off-by: Joseph Qi <[email protected]> Acked-by: Paolo Valente <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent e4ef09e commit 4168a8d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Documentation/block/bfq-iosched.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -430,13 +430,13 @@ fifo_expire_async
430430
-----------------
431431

432432
This parameter is used to set the timeout of asynchronous requests. Default
433-
value of this is 248ms.
433+
value of this is 250ms.
434434

435435
fifo_expire_sync
436436
----------------
437437

438438
This parameter is used to set the timeout of synchronous requests. Default
439-
value of this is 124ms. In case to favor synchronous requests over asynchronous
439+
value of this is 125ms. In case to favor synchronous requests over asynchronous
440440
one, this value should be decreased relative to fifo_expire_async.
441441

442442
low_latency

block/bfq-iosched.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ BFQ_BFQQ_FNS(split_coop);
162162
BFQ_BFQQ_FNS(softrt_update);
163163
#undef BFQ_BFQQ_FNS \
164164

165-
/* Expiration time of sync (0) and async (1) requests, in ns. */
165+
/* Expiration time of async (0) and sync (1) requests, in ns. */
166166
static const u64 bfq_fifo_expire[2] = { NSEC_PER_SEC / 4, NSEC_PER_SEC / 8 };
167167

168168
/* Maximum backwards seek (magic number lifted from CFQ), in KiB. */

0 commit comments

Comments
 (0)