Skip to content

Commit 44bead2

Browse files
committed
s390/con3270: use proper type for tasklet function
Get rid of this warning: drivers/s390/char/con3270.c:629:22: warning: cast between incompatible function types from ‘void (*)(struct raw3270_request *)’ to ‘void (*)(long unsigned int)’ [-Wcast-function-type] 629 | (void (*)(unsigned long)) con3270_read_tasklet, | ^ Signed-off-by: Heiko Carstens <[email protected]>
1 parent 5dddfaa commit 44bead2

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

drivers/s390/char/con3270.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -292,13 +292,15 @@ con3270_update(struct timer_list *t)
292292
* Read tasklet.
293293
*/
294294
static void
295-
con3270_read_tasklet(struct raw3270_request *rrq)
295+
con3270_read_tasklet(unsigned long data)
296296
{
297297
static char kreset_data = TW_KR;
298+
struct raw3270_request *rrq;
298299
struct con3270 *cp;
299300
unsigned long flags;
300301
int nr_up, deactivate;
301302

303+
rrq = (struct raw3270_request *)data;
302304
cp = (struct con3270 *) rrq->view;
303305
spin_lock_irqsave(&cp->view.lock, flags);
304306
nr_up = cp->nr_up;
@@ -625,8 +627,7 @@ con3270_init(void)
625627
INIT_LIST_HEAD(&condev->lines);
626628
INIT_LIST_HEAD(&condev->update);
627629
timer_setup(&condev->timer, con3270_update, 0);
628-
tasklet_init(&condev->readlet,
629-
(void (*)(unsigned long)) con3270_read_tasklet,
630+
tasklet_init(&condev->readlet, con3270_read_tasklet,
630631
(unsigned long) condev->read);
631632

632633
raw3270_add_view(&condev->view, &con3270_fn, 1, RAW3270_VIEW_LOCK_IRQ);

0 commit comments

Comments
 (0)