Skip to content

Commit 464a572

Browse files
caihuoqing1990davem330
authored andcommitted
net/mlxbf_gige: Make use of devm_platform_ioremap_resourcexxx()
Use the devm_platform_ioremap_resource_byname() helper instead of calling platform_get_resource_byname() and devm_ioremap_resource() separately Use the devm_platform_ioremap_resource() helper instead of calling platform_get_resource() and devm_ioremap_resource() separately Signed-off-by: Cai Huoqing <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 672a1c3 commit 464a572

File tree

4 files changed

+9
-36
lines changed

4 files changed

+9
-36
lines changed

drivers/net/ethernet/litex/litex_liteeth.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,6 @@ static int liteeth_probe(struct platform_device *pdev)
227227
{
228228
struct net_device *netdev;
229229
void __iomem *buf_base;
230-
struct resource *res;
231230
struct liteeth *priv;
232231
int irq, err;
233232

@@ -249,13 +248,11 @@ static int liteeth_probe(struct platform_device *pdev)
249248
}
250249
netdev->irq = irq;
251250

252-
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mac");
253-
priv->base = devm_ioremap_resource(&pdev->dev, res);
251+
priv->base = devm_platform_ioremap_resource_byname(pdev, "mac");
254252
if (IS_ERR(priv->base))
255253
return PTR_ERR(priv->base);
256254

257-
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "buffer");
258-
buf_base = devm_ioremap_resource(&pdev->dev, res);
255+
buf_base = devm_platform_ioremap_resource_byname(pdev, "buffer");
259256
if (IS_ERR(buf_base))
260257
return PTR_ERR(buf_base);
261258

drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -269,9 +269,6 @@ static int mlxbf_gige_probe(struct platform_device *pdev)
269269
{
270270
struct phy_device *phydev;
271271
struct net_device *netdev;
272-
struct resource *mac_res;
273-
struct resource *llu_res;
274-
struct resource *plu_res;
275272
struct mlxbf_gige *priv;
276273
void __iomem *llu_base;
277274
void __iomem *plu_base;
@@ -280,27 +277,15 @@ static int mlxbf_gige_probe(struct platform_device *pdev)
280277
int addr;
281278
int err;
282279

283-
mac_res = platform_get_resource(pdev, IORESOURCE_MEM, MLXBF_GIGE_RES_MAC);
284-
if (!mac_res)
285-
return -ENXIO;
286-
287-
base = devm_ioremap_resource(&pdev->dev, mac_res);
280+
base = devm_platform_ioremap_resource(pdev, MLXBF_GIGE_RES_MAC);
288281
if (IS_ERR(base))
289282
return PTR_ERR(base);
290283

291-
llu_res = platform_get_resource(pdev, IORESOURCE_MEM, MLXBF_GIGE_RES_LLU);
292-
if (!llu_res)
293-
return -ENXIO;
294-
295-
llu_base = devm_ioremap_resource(&pdev->dev, llu_res);
284+
llu_base = devm_platform_ioremap_resource(pdev, MLXBF_GIGE_RES_LLU);
296285
if (IS_ERR(llu_base))
297286
return PTR_ERR(llu_base);
298287

299-
plu_res = platform_get_resource(pdev, IORESOURCE_MEM, MLXBF_GIGE_RES_PLU);
300-
if (!plu_res)
301-
return -ENXIO;
302-
303-
plu_base = devm_ioremap_resource(&pdev->dev, plu_res);
288+
plu_base = devm_platform_ioremap_resource(pdev, MLXBF_GIGE_RES_PLU);
304289
if (IS_ERR(plu_base))
305290
return PTR_ERR(plu_base);
306291

drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -145,14 +145,9 @@ static int mlxbf_gige_mdio_write(struct mii_bus *bus, int phy_add,
145145
int mlxbf_gige_mdio_probe(struct platform_device *pdev, struct mlxbf_gige *priv)
146146
{
147147
struct device *dev = &pdev->dev;
148-
struct resource *res;
149148
int ret;
150149

151-
res = platform_get_resource(pdev, IORESOURCE_MEM, MLXBF_GIGE_RES_MDIO9);
152-
if (!res)
153-
return -ENODEV;
154-
155-
priv->mdio_io = devm_ioremap_resource(dev, res);
150+
priv->mdio_io = devm_platform_ioremap_resource(pdev, MLXBF_GIGE_RES_MDIO9);
156151
if (IS_ERR(priv->mdio_io))
157152
return PTR_ERR(priv->mdio_io);
158153

drivers/net/ethernet/ni/nixge.c

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1229,7 +1229,6 @@ static int nixge_of_get_resources(struct platform_device *pdev)
12291229
{
12301230
const struct of_device_id *of_id;
12311231
enum nixge_version version;
1232-
struct resource *ctrlres;
12331232
struct net_device *ndev;
12341233
struct nixge_priv *priv;
12351234

@@ -1248,13 +1247,10 @@ static int nixge_of_get_resources(struct platform_device *pdev)
12481247
netdev_err(ndev, "failed to map dma regs\n");
12491248
return PTR_ERR(priv->dma_regs);
12501249
}
1251-
if (version <= NIXGE_V2) {
1250+
if (version <= NIXGE_V2)
12521251
priv->ctrl_regs = priv->dma_regs + NIXGE_REG_CTRL_OFFSET;
1253-
} else {
1254-
ctrlres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
1255-
"ctrl");
1256-
priv->ctrl_regs = devm_ioremap_resource(&pdev->dev, ctrlres);
1257-
}
1252+
else
1253+
priv->ctrl_regs = devm_platform_ioremap_resource_byname(pdev, "ctrl");
12581254
if (IS_ERR(priv->ctrl_regs)) {
12591255
netdev_err(ndev, "failed to map ctrl regs\n");
12601256
return PTR_ERR(priv->ctrl_regs);

0 commit comments

Comments
 (0)