Skip to content

Commit 4744663

Browse files
Hugh Dickinstorvalds
authored andcommitted
mm: page_vma_mapped_walk(): use goto instead of while (1)
page_vma_mapped_walk() cleanup: add a label this_pte, matching next_pte, and use "goto this_pte", in place of the "while (1)" loop at the end. Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Hugh Dickins <[email protected]> Acked-by: Kirill A. Shutemov <[email protected]> Cc: Alistair Popple <[email protected]> Cc: Matthew Wilcox <[email protected]> Cc: Peter Xu <[email protected]> Cc: Ralph Campbell <[email protected]> Cc: Wang Yugui <[email protected]> Cc: Will Deacon <[email protected]> Cc: Yang Shi <[email protected]> Cc: Zi Yan <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent b3807a9 commit 4744663

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

mm/page_vma_mapped.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw)
144144
{
145145
struct mm_struct *mm = pvmw->vma->vm_mm;
146146
struct page *page = pvmw->page;
147+
unsigned long end;
147148
pgd_t *pgd;
148149
p4d_t *p4d;
149150
pud_t *pud;
@@ -233,10 +234,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw)
233234
}
234235
if (!map_pte(pvmw))
235236
goto next_pte;
236-
}
237-
while (1) {
238-
unsigned long end;
239-
237+
this_pte:
240238
if (check_pte(pvmw))
241239
return true;
242240
next_pte:
@@ -265,6 +263,7 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw)
265263
pvmw->ptl = pte_lockptr(mm, pvmw->pmd);
266264
spin_lock(pvmw->ptl);
267265
}
266+
goto this_pte;
268267
}
269268
}
270269

0 commit comments

Comments
 (0)