Skip to content

Commit 4753b46

Browse files
superm1rafaeljw
authored andcommitted
ACPI: PM: s2idle: Invert Microsoft UUID entry and exit
It was reported by a user with a Dell m15 R5 (5800H) that the keyboard backlight was turning on when entering suspend and turning off when exiting (the opposite of how it should be). The user bisected it back to commit 5dbf509 ("ACPI: PM: s2idle: Add support for new Microsoft UUID"). Previous to that commit the LEDs didn't turn off at all. Confirming in the spec, these were reversed when introduced. Fix them to match the spec. BugLink: https://gitlab.freedesktop.org/drm/amd/-/issues/1230#note_1021836 Fixes: 5dbf509 ("ACPI: PM: s2idle: Add support for new Microsoft UUID") Signed-off-by: Mario Limonciello <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 7c60610 commit 4753b46

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/acpi/x86/s2idle.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ int acpi_s2idle_prepare_late(void)
452452
if (lps0_dsm_func_mask_microsoft > 0) {
453453
acpi_sleep_run_lps0_dsm(ACPI_LPS0_SCREEN_OFF,
454454
lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);
455-
acpi_sleep_run_lps0_dsm(ACPI_LPS0_MS_EXIT,
455+
acpi_sleep_run_lps0_dsm(ACPI_LPS0_MS_ENTRY,
456456
lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);
457457
acpi_sleep_run_lps0_dsm(ACPI_LPS0_ENTRY,
458458
lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);
@@ -479,7 +479,7 @@ void acpi_s2idle_restore_early(void)
479479
if (lps0_dsm_func_mask_microsoft > 0) {
480480
acpi_sleep_run_lps0_dsm(ACPI_LPS0_EXIT,
481481
lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);
482-
acpi_sleep_run_lps0_dsm(ACPI_LPS0_MS_ENTRY,
482+
acpi_sleep_run_lps0_dsm(ACPI_LPS0_MS_EXIT,
483483
lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);
484484
acpi_sleep_run_lps0_dsm(ACPI_LPS0_SCREEN_ON,
485485
lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);

0 commit comments

Comments
 (0)