Skip to content

Commit 4acd8a4

Browse files
Saravana KannanMarc Zyngier
authored andcommitted
irqchip/qcom-pdc: Switch to IRQCHIP_PLATFORM_DRIVER and allow as a module
This patch revives changes from Saravana Kannan to switch the qcom-pdc driver to use IRQCHIP_PLATFORM_DRIVER helper macros, and allows qcom-pdc driver to be loaded as a permanent module. Earlier attempts at this ran into trouble with loading dependencies, but with Saravana's fw_devlink=on set by default now we should avoid those. [jstultz: Folded in with my changes to allow the driver to be loadable as a permenent module] Cc: Andy Gross <[email protected]> Cc: Bjorn Andersson <[email protected]> Cc: Joerg Roedel <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Jason Cooper <[email protected]> Cc: Marc Zyngier <[email protected]> Cc: Linus Walleij <[email protected]> Cc: Maulik Shah <[email protected]> Cc: Lina Iyer <[email protected]> Cc: Saravana Kannan <[email protected]> Cc: Todd Kjos <[email protected]> Cc: Greg Kroah-Hartman <[email protected]> Cc: [email protected] Cc: [email protected] Cc: [email protected] Signed-off-by: Saravana Kannan <[email protected]> Signed-off-by: John Stultz <[email protected]> Acked-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 8124c8a commit 4acd8a4

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

drivers/irqchip/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ config GOLDFISH_PIC
415415
for Goldfish based virtual platforms.
416416

417417
config QCOM_PDC
418-
bool "QCOM PDC"
418+
tristate "QCOM PDC"
419419
depends on ARCH_QCOM
420420
select IRQ_DOMAIN_HIERARCHY
421421
help

drivers/irqchip/qcom-pdc.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@
1111
#include <linux/irqdomain.h>
1212
#include <linux/io.h>
1313
#include <linux/kernel.h>
14+
#include <linux/module.h>
1415
#include <linux/of.h>
1516
#include <linux/of_address.h>
1617
#include <linux/of_device.h>
18+
#include <linux/of_irq.h>
1719
#include <linux/soc/qcom/irq.h>
1820
#include <linux/spinlock.h>
1921
#include <linux/slab.h>
@@ -459,4 +461,8 @@ static int qcom_pdc_init(struct device_node *node, struct device_node *parent)
459461
return ret;
460462
}
461463

462-
IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init);
464+
IRQCHIP_PLATFORM_DRIVER_BEGIN(qcom_pdc)
465+
IRQCHIP_MATCH("qcom,pdc", qcom_pdc_init)
466+
IRQCHIP_PLATFORM_DRIVER_END(qcom_pdc)
467+
MODULE_DESCRIPTION("Qualcomm Technologies, Inc. Power Domain Controller");
468+
MODULE_LICENSE("GPL v2");

0 commit comments

Comments
 (0)