rtc: sysfs: check features instead of ops

alexandrebelloni · alexandrebelloni · commit 4d0185e67806 · 2021-04-29T23:51:18.000+02:00
Test RTC_FEATURE_ALARM instead of relying on .set_alarm to know whether alarms are available. Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20210429214403.2610952-1-alexandre.belloni@bootlin.com
diff --git a/drivers/rtc/sysfs.c b/drivers/rtc/sysfs.c
@@ -273,7 +273,7 @@ static bool rtc_does_wakealarm(struct rtc_device *rtc)
 	if (!device_can_wakeup(rtc->dev.parent))
 		return false;
 
-	return rtc->ops->set_alarm != NULL;
+	return !!test_bit(RTC_FEATURE_ALARM, rtc->features);
 }
 
 static umode_t rtc_attr_is_visible(struct kobject *kobj,

Original file line number	Diff line number	Diff line change
`@@ -273,7 +273,7 @@ static bool rtc_does_wakealarm(struct rtc_device *rtc)`
`273`	`273`	`if (!device_can_wakeup(rtc->dev.parent))`
`274`	`274`	`return false;`
`275`	`275`
`276`		`- return rtc->ops->set_alarm != NULL;`
	`276`	`+ return !!test_bit(RTC_FEATURE_ALARM, rtc->features);`
`277`	`277`	`}`
`278`	`278`
`279`	`279`	`static umode_t rtc_attr_is_visible(struct kobject *kobj,`