Skip to content

Commit 4ff5278

Browse files
Jacopo Mondimchehab
authored andcommitted
media: i2c: max9286: Rework comments in .bound()
Rephrase a comment in .bound() callback to make it clear we register a subdev notifier and remove a redundant comment about disabling i2c auto-ack. No functional changes intended. Signed-off-by: Jacopo Mondi <[email protected]> Reviewed-by: Kieran Bingham <[email protected]> Reviewed-by: Laurent Pinchart <[email protected]> Signed-off-by: Hans Verkuil <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent 731c24f commit 4ff5278

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

drivers/media/i2c/max9286.c

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -556,9 +556,9 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier,
556556
subdev->name, src_pad, index);
557557

558558
/*
559-
* We can only register v4l2_async_notifiers, which do not provide a
560-
* means to register a complete callback. bound_sources allows us to
561-
* identify when all remote serializers have completed their probe.
559+
* As we register a subdev notifiers we won't get a .complete() callback
560+
* here, so we have to use bound_sources to identify when all remote
561+
* serializers have probed.
562562
*/
563563
if (priv->bound_sources != priv->source_mask)
564564
return 0;
@@ -575,11 +575,6 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier,
575575
*/
576576
max9286_reverse_channel_setup(priv, MAX9286_REV_AMP_HIGH);
577577
max9286_check_config_link(priv, priv->source_mask);
578-
579-
/*
580-
* Re-configure I2C with local acknowledge disabled after cameras have
581-
* probed.
582-
*/
583578
max9286_configure_i2c(priv, false);
584579

585580
return max9286_set_pixelrate(priv);

0 commit comments

Comments
 (0)