Skip to content

Commit 50c6ded

Browse files
Lang Yualexdeucher
authored andcommitted
drm/amdgpu: show both cmd id and name when psp cmd failed
To cover the corner case that people want to know the ID of an UNKNOWN CMD. Suggested-by: John Clements <[email protected]> Signed-off-by: Lang Yu <[email protected]> Reviewed-by: Huang Rui <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 3ca001a commit 50c6ded

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -469,10 +469,10 @@ psp_cmd_submit_buf(struct psp_context *psp,
469469
*/
470470
if (!skip_unsupport && (psp->cmd_buf_mem->resp.status || !timeout) && !ras_intr) {
471471
if (ucode)
472-
DRM_WARN("failed to load ucode (%s) ",
473-
amdgpu_ucode_name(ucode->ucode_id));
474-
DRM_WARN("psp gfx command (%s) failed and response status is (0x%X)\n",
475-
psp_gfx_cmd_name(psp->cmd_buf_mem->cmd_id),
472+
DRM_WARN("failed to load ucode %s(0x%X) ",
473+
amdgpu_ucode_name(ucode->ucode_id), ucode->ucode_id);
474+
DRM_WARN("psp gfx command %s(0x%X) failed and response status is (0x%X)\n",
475+
psp_gfx_cmd_name(psp->cmd_buf_mem->cmd_id), psp->cmd_buf_mem->cmd_id,
476476
psp->cmd_buf_mem->resp.status);
477477
if (!timeout) {
478478
ret = -EINVAL;

0 commit comments

Comments
 (0)