Skip to content

Commit 512c15e

Browse files
SinkFindertytso
authored andcommitted
ext4: stop inode update before return
The inode update should be stopped before returing the error code. Signed-off-by: Pan Bian <[email protected]> Link: https://lore.kernel.org/r/[email protected] Fixes: 8016e29 ("ext4: fast commit recovery path") Cc: [email protected] Reviewed-by: Harshad Shirwadkar <[email protected]> Signed-off-by: Theodore Ts'o <[email protected]>
1 parent 8210bb2 commit 512c15e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

fs/ext4/inode.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5387,8 +5387,10 @@ int ext4_setattr(struct user_namespace *mnt_userns, struct dentry *dentry,
53875387
inode->i_gid = attr->ia_gid;
53885388
error = ext4_mark_inode_dirty(handle, inode);
53895389
ext4_journal_stop(handle);
5390-
if (unlikely(error))
5390+
if (unlikely(error)) {
5391+
ext4_fc_stop_update(inode);
53915392
return error;
5393+
}
53925394
}
53935395

53945396
if (attr->ia_valid & ATTR_SIZE) {

0 commit comments

Comments
 (0)