Skip to content

Commit 51bbe7e

Browse files
committed
Merge branch 'for-5.14-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup
Pull cgroup fix from Tejun Heo: "Fix leak of filesystem context root which is triggered by LTP. Not too likely to be a problem in non-testing environments" * 'for-5.14-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup: cgroup1: fix leaked context root causing sporadic NULL deref in LTP
2 parents 82d712f + 1e7107c commit 51bbe7e

File tree

3 files changed

+2
-4
lines changed

3 files changed

+2
-4
lines changed

fs/internal.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ extern void __init chrdev_init(void);
6161
*/
6262
extern const struct fs_context_operations legacy_fs_context_ops;
6363
extern int parse_monolithic_mount_data(struct fs_context *, void *);
64-
extern void fc_drop_locked(struct fs_context *);
6564
extern void vfs_clean_context(struct fs_context *fc);
6665
extern int finish_clean_context(struct fs_context *fc);
6766

include/linux/fs_context.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ extern int vfs_get_tree(struct fs_context *fc);
141141
extern void put_fs_context(struct fs_context *fc);
142142
extern int vfs_parse_fs_param_source(struct fs_context *fc,
143143
struct fs_parameter *param);
144+
extern void fc_drop_locked(struct fs_context *fc);
144145

145146
/*
146147
* sget() wrappers to be called from the ->get_tree() op.

kernel/cgroup/cgroup-v1.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1221,9 +1221,7 @@ int cgroup1_get_tree(struct fs_context *fc)
12211221
ret = cgroup_do_get_tree(fc);
12221222

12231223
if (!ret && percpu_ref_is_dying(&ctx->root->cgrp.self.refcnt)) {
1224-
struct super_block *sb = fc->root->d_sb;
1225-
dput(fc->root);
1226-
deactivate_locked_super(sb);
1224+
fc_drop_locked(fc);
12271225
ret = 1;
12281226
}
12291227

0 commit comments

Comments
 (0)