Skip to content

Commit 5218e12

Browse files
jdelvareaxboe
authored andcommitted
block: Drop leftover references to RQF_SORTED
Commit a1ce35f ("block: remove dead elevator code") removed all users of RQF_SORTED. However it is still defined, and there is one reference left to it (which in effect is dead code). Clear it all up. Signed-off-by: Jean Delvare <[email protected]> Cc: Jens Axboe <[email protected]> Cc: Ming Lei <[email protected]> Cc: Omar Sandoval <[email protected]> Cc: Hannes Reinecke <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent 0f47227 commit 5218e12

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

block/blk-mq-debugfs.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,6 @@ static const char *const cmd_flag_name[] = {
292292

293293
#define RQF_NAME(name) [ilog2((__force u32)RQF_##name)] = #name
294294
static const char *const rqf_name[] = {
295-
RQF_NAME(SORTED),
296295
RQF_NAME(STARTED),
297296
RQF_NAME(SOFTBARRIER),
298297
RQF_NAME(FLUSH_SEQ),

block/blk-mq-sched.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,6 @@ bool blk_mq_sched_try_insert_merge(struct request_queue *q, struct request *rq)
385385
EXPORT_SYMBOL_GPL(blk_mq_sched_try_insert_merge);
386386

387387
static bool blk_mq_sched_bypass_insert(struct blk_mq_hw_ctx *hctx,
388-
bool has_sched,
389388
struct request *rq)
390389
{
391390
/*
@@ -402,9 +401,6 @@ static bool blk_mq_sched_bypass_insert(struct blk_mq_hw_ctx *hctx,
402401
if ((rq->rq_flags & RQF_FLUSH_SEQ) || blk_rq_is_passthrough(rq))
403402
return true;
404403

405-
if (has_sched)
406-
rq->rq_flags |= RQF_SORTED;
407-
408404
return false;
409405
}
410406

@@ -418,7 +414,7 @@ void blk_mq_sched_insert_request(struct request *rq, bool at_head,
418414

419415
WARN_ON(e && (rq->tag != BLK_MQ_NO_TAG));
420416

421-
if (blk_mq_sched_bypass_insert(hctx, !!e, rq)) {
417+
if (blk_mq_sched_bypass_insert(hctx, rq)) {
422418
/*
423419
* Firstly normal IO request is inserted to scheduler queue or
424420
* sw queue, meantime we add flush request to dispatch queue(

include/linux/blkdev.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,6 @@ typedef void (rq_end_io_fn)(struct request *, blk_status_t);
6565
* request flags */
6666
typedef __u32 __bitwise req_flags_t;
6767

68-
/* elevator knows about this request */
69-
#define RQF_SORTED ((__force req_flags_t)(1 << 0))
7068
/* drive already may have started this one */
7169
#define RQF_STARTED ((__force req_flags_t)(1 << 1))
7270
/* may not be passed by ioscheduler */

0 commit comments

Comments
 (0)