Skip to content

Commit 59e528c

Browse files
committed
Merge tag 'drm-misc-next-fixes-2021-05-06' of git://anongit.freedesktop.org/drm/drm-misc into drm-next
Two patches, one to fix a null pointer dereference in msm, and one to fix an unused warning for in fbdev when PROCFS is disabled. Signed-off-by: Dave Airlie <[email protected]> # gpg: Signature made Thu 06 May 2021 22:26:35 AEST # gpg: using ? key E3EF0D6F671851C5 # gpg: Can't check signature: unknown pubkey algorithm From: Maxime Ripard <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/20210506122723.oqadel7oacazywij@gilmour
2 parents 365002d + b9d79e4 commit 59e528c

File tree

4 files changed

+1
-33
lines changed

4 files changed

+1
-33
lines changed

drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -648,16 +648,6 @@ static void dpu_crtc_atomic_flush(struct drm_crtc *crtc,
648648
if (unlikely(!cstate->num_mixers))
649649
return;
650650

651-
/*
652-
* For planes without commit update, drm framework will not add
653-
* those planes to current state since hardware update is not
654-
* required. However, if those planes were power collapsed since
655-
* last commit cycle, driver has to restore the hardware state
656-
* of those planes explicitly here prior to plane flush.
657-
*/
658-
drm_atomic_crtc_for_each_plane(plane, crtc)
659-
dpu_plane_restore(plane, state);
660-
661651
/* update performance setting before crtc kickoff */
662652
dpu_core_perf_crtc_update(crtc, 1, false);
663653

drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1258,22 +1258,6 @@ static void dpu_plane_atomic_update(struct drm_plane *plane,
12581258
}
12591259
}
12601260

1261-
void dpu_plane_restore(struct drm_plane *plane, struct drm_atomic_state *state)
1262-
{
1263-
struct dpu_plane *pdpu;
1264-
1265-
if (!plane || !plane->state) {
1266-
DPU_ERROR("invalid plane\n");
1267-
return;
1268-
}
1269-
1270-
pdpu = to_dpu_plane(plane);
1271-
1272-
DPU_DEBUG_PLANE(pdpu, "\n");
1273-
1274-
dpu_plane_atomic_update(plane, state);
1275-
}
1276-
12771261
static void dpu_plane_destroy(struct drm_plane *plane)
12781262
{
12791263
struct dpu_plane *pdpu = plane ? to_dpu_plane(plane) : NULL;

drivers/gpu/drm/msm/disp/dpu1/dpu_plane.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,6 @@ bool is_dpu_plane_virtual(struct drm_plane *plane);
8484
void dpu_plane_get_ctl_flush(struct drm_plane *plane, struct dpu_hw_ctl *ctl,
8585
u32 *flush_sspp);
8686

87-
/**
88-
* dpu_plane_restore - restore hw state if previously power collapsed
89-
* @plane: Pointer to drm plane structure
90-
*/
91-
void dpu_plane_restore(struct drm_plane *plane, struct drm_atomic_state *state);
92-
9387
/**
9488
* dpu_plane_flush - final plane operations before commit flush
9589
* @plane: Pointer to drm plane structure

drivers/video/fbdev/core/fbmem.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,7 @@ static int fb_seq_show(struct seq_file *m, void *v)
733733
return 0;
734734
}
735735

736-
static const struct seq_operations proc_fb_seq_ops = {
736+
static const struct __maybe_unused seq_operations proc_fb_seq_ops = {
737737
.start = fb_seq_start,
738738
.next = fb_seq_next,
739739
.stop = fb_seq_stop,

0 commit comments

Comments
 (0)