Skip to content

Commit 6183606

Browse files
lumagrobclark
authored andcommitted
drm/msm/dsi: rename dual DSI to bonded DSI
We are preparing to support two independent DSI hosts in the DSI/DPU code. To remove possible confusion (as both configurations can be referenced as dual DSI) let's rename old "dual DSI" (two DSI hosts driving single device, with clocks being locked) to "bonded DSI". Signed-off-by: Dmitry Baryshkov <[email protected]> Reviewed-by: Abhinav Kumar <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Bjorn Andersson <[email protected]> [DB: add one extra hunk added by one previous patches] Signed-off-by: Dmitry Baryshkov <[email protected]> Signed-off-by: Rob Clark <[email protected]>
1 parent 5e2a72d commit 6183606

File tree

8 files changed

+79
-80
lines changed

8 files changed

+79
-80
lines changed

drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -737,7 +737,7 @@ struct mdp5_ctl_manager *mdp5_ctlm_init(struct drm_device *dev,
737737
}
738738

739739
/*
740-
* In Dual DSI case, CTL0 and CTL1 are always assigned to two DSI
740+
* In bonded DSI case, CTL0 and CTL1 are always assigned to two DSI
741741
* interfaces to support single FLUSH feature (Flush CTL0 and CTL1 when
742742
* only write into CTL0's FLUSH register) to keep two DSI pipes in sync.
743743
* Single FLUSH is supported from hw rev v3.0.

drivers/gpu/drm/msm/dsi/dsi.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ int msm_dsi_host_enable(struct mipi_dsi_host *host);
110110
int msm_dsi_host_disable(struct mipi_dsi_host *host);
111111
int msm_dsi_host_power_on(struct mipi_dsi_host *host,
112112
struct msm_dsi_phy_shared_timings *phy_shared_timings,
113-
bool is_dual_dsi);
113+
bool is_bonded_dsi);
114114
int msm_dsi_host_power_off(struct mipi_dsi_host *host);
115115
int msm_dsi_host_set_display_mode(struct mipi_dsi_host *host,
116116
const struct drm_display_mode *mode);
@@ -124,7 +124,7 @@ int msm_dsi_host_set_src_pll(struct mipi_dsi_host *host,
124124
void msm_dsi_host_reset_phy(struct mipi_dsi_host *host);
125125
void msm_dsi_host_get_phy_clk_req(struct mipi_dsi_host *host,
126126
struct msm_dsi_phy_clk_request *clk_req,
127-
bool is_dual_dsi);
127+
bool is_bonded_dsi);
128128
void msm_dsi_host_destroy(struct mipi_dsi_host *host);
129129
int msm_dsi_host_modeset_init(struct mipi_dsi_host *host,
130130
struct drm_device *dev);
@@ -146,8 +146,8 @@ int dsi_dma_base_get_6g(struct msm_dsi_host *msm_host, uint64_t *iova);
146146
int dsi_dma_base_get_v2(struct msm_dsi_host *msm_host, uint64_t *iova);
147147
int dsi_clk_init_v2(struct msm_dsi_host *msm_host);
148148
int dsi_clk_init_6g_v2(struct msm_dsi_host *msm_host);
149-
int dsi_calc_clk_rate_v2(struct msm_dsi_host *msm_host, bool is_dual_dsi);
150-
int dsi_calc_clk_rate_6g(struct msm_dsi_host *msm_host, bool is_dual_dsi);
149+
int dsi_calc_clk_rate_v2(struct msm_dsi_host *msm_host, bool is_bonded_dsi);
150+
int dsi_calc_clk_rate_6g(struct msm_dsi_host *msm_host, bool is_bonded_dsi);
151151
void msm_dsi_host_snapshot(struct msm_disp_state *disp_state, struct mipi_dsi_host *host);
152152
void msm_dsi_host_test_pattern_en(struct mipi_dsi_host *host);
153153

drivers/gpu/drm/msm/dsi/dsi_cfg.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ struct msm_dsi_host_cfg_ops {
4848
void* (*tx_buf_get)(struct msm_dsi_host *msm_host);
4949
void (*tx_buf_put)(struct msm_dsi_host *msm_host);
5050
int (*dma_base_get)(struct msm_dsi_host *msm_host, uint64_t *iova);
51-
int (*calc_clk_rate)(struct msm_dsi_host *msm_host, bool is_dual_dsi);
51+
int (*calc_clk_rate)(struct msm_dsi_host *msm_host, bool is_bonded_dsi);
5252
};
5353

5454
struct msm_dsi_cfg_handler {

drivers/gpu/drm/msm/dsi/dsi_host.c

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -673,30 +673,30 @@ void dsi_link_clk_disable_v2(struct msm_dsi_host *msm_host)
673673
clk_disable_unprepare(msm_host->byte_clk);
674674
}
675675

676-
static u32 dsi_get_pclk_rate(struct msm_dsi_host *msm_host, bool is_dual_dsi)
676+
static u32 dsi_get_pclk_rate(struct msm_dsi_host *msm_host, bool is_bonded_dsi)
677677
{
678678
struct drm_display_mode *mode = msm_host->mode;
679679
u32 pclk_rate;
680680

681681
pclk_rate = mode->clock * 1000;
682682

683683
/*
684-
* For dual DSI mode, the current DRM mode has the complete width of the
684+
* For bonded DSI mode, the current DRM mode has the complete width of the
685685
* panel. Since, the complete panel is driven by two DSI controllers,
686686
* the clock rates have to be split between the two dsi controllers.
687687
* Adjust the byte and pixel clock rates for each dsi host accordingly.
688688
*/
689-
if (is_dual_dsi)
689+
if (is_bonded_dsi)
690690
pclk_rate /= 2;
691691

692692
return pclk_rate;
693693
}
694694

695-
static void dsi_calc_pclk(struct msm_dsi_host *msm_host, bool is_dual_dsi)
695+
static void dsi_calc_pclk(struct msm_dsi_host *msm_host, bool is_bonded_dsi)
696696
{
697697
u8 lanes = msm_host->lanes;
698698
u32 bpp = dsi_get_bpp(msm_host->format);
699-
u32 pclk_rate = dsi_get_pclk_rate(msm_host, is_dual_dsi);
699+
u32 pclk_rate = dsi_get_pclk_rate(msm_host, is_bonded_dsi);
700700
u64 pclk_bpp = (u64)pclk_rate * bpp;
701701

702702
if (lanes == 0) {
@@ -718,28 +718,28 @@ static void dsi_calc_pclk(struct msm_dsi_host *msm_host, bool is_dual_dsi)
718718

719719
}
720720

721-
int dsi_calc_clk_rate_6g(struct msm_dsi_host *msm_host, bool is_dual_dsi)
721+
int dsi_calc_clk_rate_6g(struct msm_dsi_host *msm_host, bool is_bonded_dsi)
722722
{
723723
if (!msm_host->mode) {
724724
pr_err("%s: mode not set\n", __func__);
725725
return -EINVAL;
726726
}
727727

728-
dsi_calc_pclk(msm_host, is_dual_dsi);
728+
dsi_calc_pclk(msm_host, is_bonded_dsi);
729729
msm_host->esc_clk_rate = clk_get_rate(msm_host->esc_clk);
730730
return 0;
731731
}
732732

733-
int dsi_calc_clk_rate_v2(struct msm_dsi_host *msm_host, bool is_dual_dsi)
733+
int dsi_calc_clk_rate_v2(struct msm_dsi_host *msm_host, bool is_bonded_dsi)
734734
{
735735
u32 bpp = dsi_get_bpp(msm_host->format);
736736
u64 pclk_bpp;
737737
unsigned int esc_mhz, esc_div;
738738
unsigned long byte_mhz;
739739

740-
dsi_calc_pclk(msm_host, is_dual_dsi);
740+
dsi_calc_pclk(msm_host, is_bonded_dsi);
741741

742-
pclk_bpp = (u64)dsi_get_pclk_rate(msm_host, is_dual_dsi) * bpp;
742+
pclk_bpp = (u64)dsi_get_pclk_rate(msm_host, is_bonded_dsi) * bpp;
743743
do_div(pclk_bpp, 8);
744744
msm_host->src_clk_rate = pclk_bpp;
745745

@@ -939,7 +939,7 @@ static void dsi_ctrl_config(struct msm_dsi_host *msm_host, bool enable,
939939
dsi_write(msm_host, REG_DSI_CPHY_MODE_CTRL, BIT(0));
940940
}
941941

942-
static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_dual_dsi)
942+
static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_bonded_dsi)
943943
{
944944
struct drm_display_mode *mode = msm_host->mode;
945945
u32 hs_start = 0, vs_start = 0; /* take sync start as 0 */
@@ -957,13 +957,13 @@ static void dsi_timing_setup(struct msm_dsi_host *msm_host, bool is_dual_dsi)
957957
DBG("");
958958

959959
/*
960-
* For dual DSI mode, the current DRM mode has
960+
* For bonded DSI mode, the current DRM mode has
961961
* the complete width of the panel. Since, the complete
962962
* panel is driven by two DSI controllers, the horizontal
963963
* timings have to be split between the two dsi controllers.
964964
* Adjust the DSI host timing values accordingly.
965965
*/
966-
if (is_dual_dsi) {
966+
if (is_bonded_dsi) {
967967
h_total /= 2;
968968
hs_end /= 2;
969969
ha_start /= 2;
@@ -2288,13 +2288,13 @@ void msm_dsi_host_reset_phy(struct mipi_dsi_host *host)
22882288

22892289
void msm_dsi_host_get_phy_clk_req(struct mipi_dsi_host *host,
22902290
struct msm_dsi_phy_clk_request *clk_req,
2291-
bool is_dual_dsi)
2291+
bool is_bonded_dsi)
22922292
{
22932293
struct msm_dsi_host *msm_host = to_msm_dsi_host(host);
22942294
const struct msm_dsi_cfg_handler *cfg_hnd = msm_host->cfg_hnd;
22952295
int ret;
22962296

2297-
ret = cfg_hnd->ops->calc_clk_rate(msm_host, is_dual_dsi);
2297+
ret = cfg_hnd->ops->calc_clk_rate(msm_host, is_bonded_dsi);
22982298
if (ret) {
22992299
pr_err("%s: unable to calc clk rate, %d\n", __func__, ret);
23002300
return;
@@ -2364,7 +2364,7 @@ static void msm_dsi_sfpb_config(struct msm_dsi_host *msm_host, bool enable)
23642364

23652365
int msm_dsi_host_power_on(struct mipi_dsi_host *host,
23662366
struct msm_dsi_phy_shared_timings *phy_shared_timings,
2367-
bool is_dual_dsi)
2367+
bool is_bonded_dsi)
23682368
{
23692369
struct msm_dsi_host *msm_host = to_msm_dsi_host(host);
23702370
const struct msm_dsi_cfg_handler *cfg_hnd = msm_host->cfg_hnd;
@@ -2402,7 +2402,7 @@ int msm_dsi_host_power_on(struct mipi_dsi_host *host,
24022402
goto fail_disable_clk;
24032403
}
24042404

2405-
dsi_timing_setup(msm_host, is_dual_dsi);
2405+
dsi_timing_setup(msm_host, is_bonded_dsi);
24062406
dsi_sw_reset(msm_host);
24072407
dsi_ctrl_config(msm_host, true, phy_shared_timings);
24082408

0 commit comments

Comments
 (0)