Skip to content

Commit 62c211b

Browse files
elongbugzehortigoza
authored andcommitted
drm/i915/display: Do not allow DC3CO if PSR SF is enabled
Even though GEN12+ HW supports PSR + DC3CO, DMC's HW DC3CO exit mechanism has an issue with using of Selective Fecth and PSR2 manual tracking. And as some GEN12+ platforms (RKL, ADL-S) don't support PSR2 HW tracking, Selective Fetch will be enabled by default on that platforms. Therefore if the system enables PSR Selective Fetch / PSR manual tracking, it does not allow DC3CO dc state, in that case. When this DC3CO exit issue is addressed while PSR Selective Fetch is enabled, this restriction should be removed. v2: Address Jose's review comment. - Fix typo - Move check routine of DC3CO ability to tgl_dc3co_exitline_compute_config() v3: Change the check routine of enablement of psr2 sel fetch. (Jose) Cc: José Roberto de Souza <[email protected]> Cc: Anshuman Gupta <[email protected]> Signed-off-by: Gwan-gyeong Mun <[email protected]> Reviewed-by: José Roberto de Souza <[email protected]> Signed-off-by: José Roberto de Souza <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 63e654f commit 62c211b

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

drivers/gpu/drm/i915/display/intel_psr.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -654,6 +654,13 @@ tgl_dc3co_exitline_compute_config(struct intel_dp *intel_dp,
654654
struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
655655
u32 exit_scanlines;
656656

657+
/*
658+
* DMC's DC3CO exit mechanism has an issue with Selective Fecth
659+
* TODO: when the issue is addressed, this restriction should be removed.
660+
*/
661+
if (crtc_state->enable_psr2_sel_fetch)
662+
return;
663+
657664
if (!(dev_priv->csr.allowed_dc_mask & DC_STATE_EN_DC3CO))
658665
return;
659666

0 commit comments

Comments
 (0)