Skip to content

Commit 66291b6

Browse files
committed
ALSA: usb-audio: Fix superfluous autosuspend recovery
The change to restore the autosuspend from the disabled state uses a wrong check: namely, it should have been the exact comparison of the quirk_type instead of the bitwise and (&). Otherwise it matches wrongly with the other quirk types. Although re-enabling the autosuspend for the already enabled device shouldn't matter much, it's better to fix the unbalanced call. Fixes: 9799110 ("ALSA: usb-audio: Disable USB autosuspend properly in setup_disable_autosuspend()") Cc: <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 4511781 commit 66291b6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/usb/card.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -907,7 +907,7 @@ static void usb_audio_disconnect(struct usb_interface *intf)
907907
}
908908
}
909909

910-
if (chip->quirk_type & QUIRK_SETUP_DISABLE_AUTOSUSPEND)
910+
if (chip->quirk_type == QUIRK_SETUP_DISABLE_AUTOSUSPEND)
911911
usb_enable_autosuspend(interface_to_usbdev(intf));
912912

913913
chip->num_interfaces--;

0 commit comments

Comments
 (0)