Skip to content

Commit 663d946

Browse files
Saravana Kannandavem330
authored andcommitted
net: mdio-mux: Delete unnecessary devm_kfree
The whole point of devm_* APIs is that you don't have to undo them if you are returning an error that's going to get propagated out of a probe() function. So delete unnecessary devm_kfree() call in the error return path. Fixes: b601616 ("mdio: mux: Correct mdio_mux_init error path issues") Signed-off-by: Saravana Kannan <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Acked-by: Marc Zyngier <[email protected]> Tested-by: Marc Zyngier <[email protected]> Acked-by: Kevin Hilman <[email protected]> Tested-by: Kevin Hilman <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent ed5d293 commit 663d946

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/net/mdio/mdio-mux.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,6 @@ int mdio_mux_init(struct device *dev,
181181
}
182182

183183
dev_err(dev, "Error: No acceptable child buses found\n");
184-
devm_kfree(dev, pb);
185184
err_pb_kz:
186185
put_device(&parent_bus->dev);
187186
err_parent_bus:

0 commit comments

Comments
 (0)