Skip to content

Commit 692a3b9

Browse files
vireshkrafaeljw
authored andcommitted
cpufreq: acpi: Remove acpi_cpufreq_cpu_ready()
The ready() callback was implemented earlier for acpi-cpufreq driver as we wanted to use policy->cpuinfo.max_freq for which the policy was required to be verified. That is no longer the case and we can do the pr_warn() right from ->init() callback now. Remove acpi_cpufreq_cpu_ready(). Signed-off-by: Viresh Kumar <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent b2a6181 commit 692a3b9

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

drivers/cpufreq/acpi-cpufreq.c

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -889,6 +889,9 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
889889
policy->fast_switch_possible = !acpi_pstate_strict &&
890890
!(policy_is_shared(policy) && policy->shared_type != CPUFREQ_SHARED_TYPE_ANY);
891891

892+
if (perf->states[0].core_frequency * 1000 != freq_table[0].frequency)
893+
pr_warn(FW_WARN "P-state 0 is not max freq\n");
894+
892895
return result;
893896

894897
err_unreg:
@@ -918,16 +921,6 @@ static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy)
918921
return 0;
919922
}
920923

921-
static void acpi_cpufreq_cpu_ready(struct cpufreq_policy *policy)
922-
{
923-
struct acpi_processor_performance *perf = per_cpu_ptr(acpi_perf_data,
924-
policy->cpu);
925-
unsigned int freq = policy->freq_table[0].frequency;
926-
927-
if (perf->states[0].core_frequency * 1000 != freq)
928-
pr_warn(FW_WARN "P-state 0 is not max freq\n");
929-
}
930-
931924
static int acpi_cpufreq_resume(struct cpufreq_policy *policy)
932925
{
933926
struct acpi_cpufreq_data *data = policy->driver_data;
@@ -955,7 +948,6 @@ static struct cpufreq_driver acpi_cpufreq_driver = {
955948
.bios_limit = acpi_processor_get_bios_limit,
956949
.init = acpi_cpufreq_cpu_init,
957950
.exit = acpi_cpufreq_cpu_exit,
958-
.ready = acpi_cpufreq_cpu_ready,
959951
.resume = acpi_cpufreq_resume,
960952
.name = "acpi-cpufreq",
961953
.attr = acpi_cpufreq_attr,

0 commit comments

Comments
 (0)