Skip to content

Commit 701b54b

Browse files
odmykojwrdegoede
authored andcommitted
platform/mellanox: mlxreg-hotplug: Revert "move to use request_irq by IRQF_NO_AUTOEN flag"
It causes mlxreg-hotplug probing failure: request_threaded_irq() returns -EINVAL due to true value of condition: ((irqflags & IRQF_SHARED) && (irqflags & IRQF_NO_AUTOEN)) after flag "IRQF_NO_AUTOEN" has been added to: err = devm_request_irq(&pdev->dev, priv->irq, mlxreg_hotplug_irq_handler, IRQF_TRIGGER_FALLING | IRQF_SHARED | IRQF_NO_AUTOEN, "mlxreg-hotplug", priv); This reverts commit bee3ecf ("platform/mellanox: mlxreg-hotplug: move to use request_irq by IRQF_NO_AUTOEN flag"). Signed-off-by: Mykola Kostenok <[email protected]> Acked-by: Vadim Pasternak <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Hans de Goede <[email protected]>
1 parent 6325ce1 commit 701b54b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/platform/mellanox/mlxreg-hotplug.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -683,13 +683,13 @@ static int mlxreg_hotplug_probe(struct platform_device *pdev)
683683

684684
err = devm_request_irq(&pdev->dev, priv->irq,
685685
mlxreg_hotplug_irq_handler, IRQF_TRIGGER_FALLING
686-
| IRQF_SHARED | IRQF_NO_AUTOEN,
687-
"mlxreg-hotplug", priv);
686+
| IRQF_SHARED, "mlxreg-hotplug", priv);
688687
if (err) {
689688
dev_err(&pdev->dev, "Failed to request irq: %d\n", err);
690689
return err;
691690
}
692691

692+
disable_irq(priv->irq);
693693
spin_lock_init(&priv->lock);
694694
INIT_DELAYED_WORK(&priv->dwork_irq, mlxreg_hotplug_work_handler);
695695
dev_set_drvdata(&pdev->dev, priv);

0 commit comments

Comments
 (0)