Skip to content

Commit 7061803

Browse files
commodojic23
commodo
authored and
jic23
committed
iio: hid-sensors: select IIO_TRIGGERED_BUFFER under HID_SENSOR_IIO_TRIGGER
During commit 067fda1 ("iio: hid-sensors: move triggered buffer setup into hid_sensor_setup_trigger"), the iio_triggered_buffer_{setup,cleanup}() functions got moved under the hid-sensor-trigger module. The above change works fine, if any of the sensors get built. However, when only the common hid-sensor-trigger module gets built (and none of the drivers), then the IIO_TRIGGERED_BUFFER symbol isn't selected/enforced. Previously, each driver would enforce/select the IIO_TRIGGERED_BUFFER symbol. With this change the HID_SENSOR_IIO_TRIGGER (for the hid-sensor-trigger module) will enforce that IIO_TRIGGERED_BUFFER gets selected. All HID sensor drivers select the HID_SENSOR_IIO_TRIGGER symbol. So, this change removes the IIO_TRIGGERED_BUFFER enforcement from each driver. Fixes: 067fda1 ("iio: hid-sensors: move triggered buffer setup into hid_sensor_setup_trigger") Reported-by: Thomas Deutschmann <[email protected]> Cc: Srinivas Pandruvada <[email protected]> Signed-off-by: Alexandru Ardelean <[email protected]> Acked-by: Srinivas Pandruvada <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jonathan Cameron <[email protected]>
1 parent a2fa924 commit 7061803

File tree

9 files changed

+1
-10
lines changed

9 files changed

+1
-10
lines changed

‎drivers/iio/accel/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,6 @@ config DMARD10
229229
config HID_SENSOR_ACCEL_3D
230230
depends on HID_SENSOR_HUB
231231
select IIO_BUFFER
232-
select IIO_TRIGGERED_BUFFER
233232
select HID_SENSOR_IIO_COMMON
234233
select HID_SENSOR_IIO_TRIGGER
235234
tristate "HID Accelerometers 3D"

‎drivers/iio/common/hid-sensors/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ config HID_SENSOR_IIO_TRIGGER
1919
tristate "Common module (trigger) for all HID Sensor IIO drivers"
2020
depends on HID_SENSOR_HUB && HID_SENSOR_IIO_COMMON && IIO_BUFFER
2121
select IIO_TRIGGER
22+
select IIO_TRIGGERED_BUFFER
2223
help
2324
Say yes here to build trigger support for HID sensors.
2425
Triggers will be send if all requested attributes were read.

‎drivers/iio/gyro/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ config FXAS21002C_SPI
111111
config HID_SENSOR_GYRO_3D
112112
depends on HID_SENSOR_HUB
113113
select IIO_BUFFER
114-
select IIO_TRIGGERED_BUFFER
115114
select HID_SENSOR_IIO_COMMON
116115
select HID_SENSOR_IIO_TRIGGER
117116
tristate "HID Gyroscope 3D"

‎drivers/iio/humidity/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ config HID_SENSOR_HUMIDITY
5252
tristate "HID Environmental humidity sensor"
5353
depends on HID_SENSOR_HUB
5454
select IIO_BUFFER
55-
select IIO_TRIGGERED_BUFFER
5655
select HID_SENSOR_IIO_COMMON
5756
select HID_SENSOR_IIO_TRIGGER
5857
help

‎drivers/iio/light/Kconfig

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,6 @@ config ISL29125
256256
config HID_SENSOR_ALS
257257
depends on HID_SENSOR_HUB
258258
select IIO_BUFFER
259-
select IIO_TRIGGERED_BUFFER
260259
select HID_SENSOR_IIO_COMMON
261260
select HID_SENSOR_IIO_TRIGGER
262261
tristate "HID ALS"
@@ -270,7 +269,6 @@ config HID_SENSOR_ALS
270269
config HID_SENSOR_PROX
271270
depends on HID_SENSOR_HUB
272271
select IIO_BUFFER
273-
select IIO_TRIGGERED_BUFFER
274272
select HID_SENSOR_IIO_COMMON
275273
select HID_SENSOR_IIO_TRIGGER
276274
tristate "HID PROX"

‎drivers/iio/magnetometer/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ config MAG3110
9595
config HID_SENSOR_MAGNETOMETER_3D
9696
depends on HID_SENSOR_HUB
9797
select IIO_BUFFER
98-
select IIO_TRIGGERED_BUFFER
9998
select HID_SENSOR_IIO_COMMON
10099
select HID_SENSOR_IIO_TRIGGER
101100
tristate "HID Magenetometer 3D"

‎drivers/iio/orientation/Kconfig

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ menu "Inclinometer sensors"
99
config HID_SENSOR_INCLINOMETER_3D
1010
depends on HID_SENSOR_HUB
1111
select IIO_BUFFER
12-
select IIO_TRIGGERED_BUFFER
1312
select HID_SENSOR_IIO_COMMON
1413
select HID_SENSOR_IIO_TRIGGER
1514
tristate "HID Inclinometer 3D"
@@ -20,7 +19,6 @@ config HID_SENSOR_INCLINOMETER_3D
2019
config HID_SENSOR_DEVICE_ROTATION
2120
depends on HID_SENSOR_HUB
2221
select IIO_BUFFER
23-
select IIO_TRIGGERED_BUFFER
2422
select HID_SENSOR_IIO_COMMON
2523
select HID_SENSOR_IIO_TRIGGER
2624
tristate "HID Device Rotation"

‎drivers/iio/pressure/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ config DPS310
7979
config HID_SENSOR_PRESS
8080
depends on HID_SENSOR_HUB
8181
select IIO_BUFFER
82-
select IIO_TRIGGERED_BUFFER
8382
select HID_SENSOR_IIO_COMMON
8483
select HID_SENSOR_IIO_TRIGGER
8584
tristate "HID PRESS"

‎drivers/iio/temperature/Kconfig

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ config HID_SENSOR_TEMP
4545
tristate "HID Environmental temperature sensor"
4646
depends on HID_SENSOR_HUB
4747
select IIO_BUFFER
48-
select IIO_TRIGGERED_BUFFER
4948
select HID_SENSOR_IIO_COMMON
5049
select HID_SENSOR_IIO_TRIGGER
5150
help

0 commit comments

Comments
 (0)