Skip to content

Commit 78ecc89

Browse files
vladimirolteandavem330
authored andcommitted
net: say "local" instead of "static" addresses in ndo_dflt_fdb_{add,del}
"Static" is a loaded word, and probably not what the author meant when the code was written. In particular, this looks weird: $ bridge fdb add dev swp0 00:01:02:03:04:05 local # totally fine, but $ bridge fdb add dev swp0 00:01:02:03:04:05 static [ 2020.708298] swp0: FDB only supports static addresses # hmm what? By looking at the implementation which uses dev_uc_add/dev_uc_del it is absolutely clear that only local addresses are supported, and the proper Network Unreachability Detection state is being used for this purpose (user space indeed sets NUD_PERMANENT when local addresses are meant). So it is just the message that is wrong, fix it. Signed-off-by: Vladimir Oltean <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 23ac0b4 commit 78ecc89

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

net/core/rtnetlink.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3947,7 +3947,7 @@ int ndo_dflt_fdb_add(struct ndmsg *ndm,
39473947
* implement its own handler for this.
39483948
*/
39493949
if (ndm->ndm_state && !(ndm->ndm_state & NUD_PERMANENT)) {
3950-
netdev_info(dev, "FDB only supports static addresses\n");
3950+
netdev_info(dev, "default FDB implementation only supports local addresses\n");
39513951
return err;
39523952
}
39533953

@@ -4086,7 +4086,7 @@ int ndo_dflt_fdb_del(struct ndmsg *ndm,
40864086
* implement its own handler for this.
40874087
*/
40884088
if (!(ndm->ndm_state & NUD_PERMANENT)) {
4089-
netdev_info(dev, "FDB only supports static addresses\n");
4089+
netdev_info(dev, "default FDB implementation only supports local addresses\n");
40904090
return err;
40914091
}
40924092

0 commit comments

Comments
 (0)