Skip to content

Commit 80c7917

Browse files
committed
Merge tag 'drm-intel-fixes-2021-07-28' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes
Display related fixes: - Fix vbt port mask - Fix around reading the right DSC disable fuse in display_ver 10 - Split display version 9 and 10 in intel_setup_outputs Signed-off-by: Dave Airlie <[email protected]> From: Rodrigo Vivi <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
2 parents 89e7ffd + b4bde55 commit 80c7917

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

drivers/gpu/drm/i915/display/intel_bios.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2166,7 +2166,8 @@ static void
21662166
init_vbt_missing_defaults(struct drm_i915_private *i915)
21672167
{
21682168
enum port port;
2169-
int ports = PORT_A | PORT_B | PORT_C | PORT_D | PORT_E | PORT_F;
2169+
int ports = BIT(PORT_A) | BIT(PORT_B) | BIT(PORT_C) |
2170+
BIT(PORT_D) | BIT(PORT_E) | BIT(PORT_F);
21702171

21712172
if (!HAS_DDI(i915) && !IS_CHERRYVIEW(i915))
21722173
return;

drivers/gpu/drm/i915/display/intel_display.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11361,13 +11361,19 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
1136111361
intel_ddi_init(dev_priv, PORT_B);
1136211362
intel_ddi_init(dev_priv, PORT_C);
1136311363
vlv_dsi_init(dev_priv);
11364-
} else if (DISPLAY_VER(dev_priv) >= 9) {
11364+
} else if (DISPLAY_VER(dev_priv) == 10) {
1136511365
intel_ddi_init(dev_priv, PORT_A);
1136611366
intel_ddi_init(dev_priv, PORT_B);
1136711367
intel_ddi_init(dev_priv, PORT_C);
1136811368
intel_ddi_init(dev_priv, PORT_D);
1136911369
intel_ddi_init(dev_priv, PORT_E);
1137011370
intel_ddi_init(dev_priv, PORT_F);
11371+
} else if (DISPLAY_VER(dev_priv) >= 9) {
11372+
intel_ddi_init(dev_priv, PORT_A);
11373+
intel_ddi_init(dev_priv, PORT_B);
11374+
intel_ddi_init(dev_priv, PORT_C);
11375+
intel_ddi_init(dev_priv, PORT_D);
11376+
intel_ddi_init(dev_priv, PORT_E);
1137111377
} else if (HAS_DDI(dev_priv)) {
1137211378
u32 found;
1137311379

drivers/gpu/drm/i915/intel_device_info.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
325325
info->pipe_mask &= ~BIT(PIPE_C);
326326
info->cpu_transcoder_mask &= ~BIT(TRANSCODER_C);
327327
}
328-
} else if (HAS_DISPLAY(dev_priv) && GRAPHICS_VER(dev_priv) >= 9) {
328+
} else if (HAS_DISPLAY(dev_priv) && DISPLAY_VER(dev_priv) >= 9) {
329329
u32 dfsm = intel_de_read(dev_priv, SKL_DFSM);
330330

331331
if (dfsm & SKL_DFSM_PIPE_A_DISABLE) {
@@ -340,7 +340,8 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
340340
info->pipe_mask &= ~BIT(PIPE_C);
341341
info->cpu_transcoder_mask &= ~BIT(TRANSCODER_C);
342342
}
343-
if (GRAPHICS_VER(dev_priv) >= 12 &&
343+
344+
if (DISPLAY_VER(dev_priv) >= 12 &&
344345
(dfsm & TGL_DFSM_PIPE_D_DISABLE)) {
345346
info->pipe_mask &= ~BIT(PIPE_D);
346347
info->cpu_transcoder_mask &= ~BIT(TRANSCODER_D);
@@ -352,10 +353,10 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
352353
if (dfsm & SKL_DFSM_DISPLAY_PM_DISABLE)
353354
info->display.has_fbc = 0;
354355

355-
if (GRAPHICS_VER(dev_priv) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE))
356+
if (DISPLAY_VER(dev_priv) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE))
356357
info->display.has_dmc = 0;
357358

358-
if (GRAPHICS_VER(dev_priv) >= 10 &&
359+
if (DISPLAY_VER(dev_priv) >= 10 &&
359360
(dfsm & CNL_DFSM_DISPLAY_DSC_DISABLE))
360361
info->display.has_dsc = 0;
361362
}

0 commit comments

Comments
 (0)