Skip to content

Commit 83189d1

Browse files
chuckleverTrond Myklebust
authored andcommitted
xprtrdma: Don't display r_xprt memory addresses in tracepoints
The remote peer's IP address is sufficient, and does not expose details of the kernel's memory layout. Signed-off-by: Chuck Lever <[email protected]> Signed-off-by: Trond Myklebust <[email protected]>
1 parent 6b147ea commit 83189d1

File tree

1 file changed

+19
-32
lines changed

1 file changed

+19
-32
lines changed

include/trace/events/rpcrdma.h

Lines changed: 19 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -190,19 +190,17 @@ DECLARE_EVENT_CLASS(xprtrdma_rxprt,
190190
TP_ARGS(r_xprt),
191191

192192
TP_STRUCT__entry(
193-
__field(const void *, r_xprt)
194193
__string(addr, rpcrdma_addrstr(r_xprt))
195194
__string(port, rpcrdma_portstr(r_xprt))
196195
),
197196

198197
TP_fast_assign(
199-
__entry->r_xprt = r_xprt;
200198
__assign_str(addr, rpcrdma_addrstr(r_xprt));
201199
__assign_str(port, rpcrdma_portstr(r_xprt));
202200
),
203201

204-
TP_printk("peer=[%s]:%s r_xprt=%p",
205-
__get_str(addr), __get_str(port), __entry->r_xprt
202+
TP_printk("peer=[%s]:%s",
203+
__get_str(addr), __get_str(port)
206204
)
207205
);
208206

@@ -222,23 +220,21 @@ DECLARE_EVENT_CLASS(xprtrdma_connect_class,
222220
TP_ARGS(r_xprt, rc),
223221

224222
TP_STRUCT__entry(
225-
__field(const void *, r_xprt)
226223
__field(int, rc)
227224
__field(int, connect_status)
228225
__string(addr, rpcrdma_addrstr(r_xprt))
229226
__string(port, rpcrdma_portstr(r_xprt))
230227
),
231228

232229
TP_fast_assign(
233-
__entry->r_xprt = r_xprt;
234230
__entry->rc = rc;
235231
__entry->connect_status = r_xprt->rx_ep->re_connect_status;
236232
__assign_str(addr, rpcrdma_addrstr(r_xprt));
237233
__assign_str(port, rpcrdma_portstr(r_xprt));
238234
),
239235

240-
TP_printk("peer=[%s]:%s r_xprt=%p: rc=%d connection status=%d",
241-
__get_str(addr), __get_str(port), __entry->r_xprt,
236+
TP_printk("peer=[%s]:%s rc=%d connection status=%d",
237+
__get_str(addr), __get_str(port),
242238
__entry->rc, __entry->connect_status
243239
)
244240
);
@@ -535,22 +531,19 @@ TRACE_EVENT(xprtrdma_op_connect,
535531
TP_ARGS(r_xprt, delay),
536532

537533
TP_STRUCT__entry(
538-
__field(const void *, r_xprt)
539534
__field(unsigned long, delay)
540535
__string(addr, rpcrdma_addrstr(r_xprt))
541536
__string(port, rpcrdma_portstr(r_xprt))
542537
),
543538

544539
TP_fast_assign(
545-
__entry->r_xprt = r_xprt;
546540
__entry->delay = delay;
547541
__assign_str(addr, rpcrdma_addrstr(r_xprt));
548542
__assign_str(port, rpcrdma_portstr(r_xprt));
549543
),
550544

551-
TP_printk("peer=[%s]:%s r_xprt=%p delay=%lu",
552-
__get_str(addr), __get_str(port), __entry->r_xprt,
553-
__entry->delay
545+
TP_printk("peer=[%s]:%s delay=%lu",
546+
__get_str(addr), __get_str(port), __entry->delay
554547
)
555548
);
556549

@@ -565,23 +558,21 @@ TRACE_EVENT(xprtrdma_op_set_cto,
565558
TP_ARGS(r_xprt, connect, reconnect),
566559

567560
TP_STRUCT__entry(
568-
__field(const void *, r_xprt)
569561
__field(unsigned long, connect)
570562
__field(unsigned long, reconnect)
571563
__string(addr, rpcrdma_addrstr(r_xprt))
572564
__string(port, rpcrdma_portstr(r_xprt))
573565
),
574566

575567
TP_fast_assign(
576-
__entry->r_xprt = r_xprt;
577568
__entry->connect = connect;
578569
__entry->reconnect = reconnect;
579570
__assign_str(addr, rpcrdma_addrstr(r_xprt));
580571
__assign_str(port, rpcrdma_portstr(r_xprt));
581572
),
582573

583-
TP_printk("peer=[%s]:%s r_xprt=%p: connect=%lu reconnect=%lu",
584-
__get_str(addr), __get_str(port), __entry->r_xprt,
574+
TP_printk("peer=[%s]:%s connect=%lu reconnect=%lu",
575+
__get_str(addr), __get_str(port),
585576
__entry->connect / HZ, __entry->reconnect / HZ
586577
)
587578
);
@@ -631,22 +622,19 @@ TRACE_EVENT(xprtrdma_createmrs,
631622
TP_ARGS(r_xprt, count),
632623

633624
TP_STRUCT__entry(
634-
__field(const void *, r_xprt)
635625
__string(addr, rpcrdma_addrstr(r_xprt))
636626
__string(port, rpcrdma_portstr(r_xprt))
637627
__field(unsigned int, count)
638628
),
639629

640630
TP_fast_assign(
641-
__entry->r_xprt = r_xprt;
642631
__entry->count = count;
643632
__assign_str(addr, rpcrdma_addrstr(r_xprt));
644633
__assign_str(port, rpcrdma_portstr(r_xprt));
645634
),
646635

647-
TP_printk("peer=[%s]:%s r_xprt=%p: created %u MRs",
648-
__get_str(addr), __get_str(port), __entry->r_xprt,
649-
__entry->count
636+
TP_printk("peer=[%s]:%s created %u MRs",
637+
__get_str(addr), __get_str(port), __entry->count
650638
)
651639
);
652640

@@ -869,7 +857,7 @@ TRACE_EVENT(xprtrdma_post_recvs,
869857
TP_ARGS(r_xprt, count, status),
870858

871859
TP_STRUCT__entry(
872-
__field(const void *, r_xprt)
860+
__field(u32, cq_id)
873861
__field(unsigned int, count)
874862
__field(int, status)
875863
__field(int, posted)
@@ -878,16 +866,18 @@ TRACE_EVENT(xprtrdma_post_recvs,
878866
),
879867

880868
TP_fast_assign(
881-
__entry->r_xprt = r_xprt;
869+
const struct rpcrdma_ep *ep = r_xprt->rx_ep;
870+
871+
__entry->cq_id = ep->re_attr.recv_cq->res.id;
882872
__entry->count = count;
883873
__entry->status = status;
884-
__entry->posted = r_xprt->rx_ep->re_receive_count;
874+
__entry->posted = ep->re_receive_count;
885875
__assign_str(addr, rpcrdma_addrstr(r_xprt));
886876
__assign_str(port, rpcrdma_portstr(r_xprt));
887877
),
888878

889-
TP_printk("peer=[%s]:%s r_xprt=%p: %u new recvs, %d active (rc %d)",
890-
__get_str(addr), __get_str(port), __entry->r_xprt,
879+
TP_printk("peer=[%s]:%s cq.id=%d %u new recvs, %d active (rc %d)",
880+
__get_str(addr), __get_str(port), __entry->cq_id,
891881
__entry->count, __entry->posted, __entry->status
892882
)
893883
);
@@ -1289,22 +1279,19 @@ TRACE_EVENT(xprtrdma_cb_setup,
12891279
TP_ARGS(r_xprt, reqs),
12901280

12911281
TP_STRUCT__entry(
1292-
__field(const void *, r_xprt)
12931282
__field(unsigned int, reqs)
12941283
__string(addr, rpcrdma_addrstr(r_xprt))
12951284
__string(port, rpcrdma_portstr(r_xprt))
12961285
),
12971286

12981287
TP_fast_assign(
1299-
__entry->r_xprt = r_xprt;
13001288
__entry->reqs = reqs;
13011289
__assign_str(addr, rpcrdma_addrstr(r_xprt));
13021290
__assign_str(port, rpcrdma_portstr(r_xprt));
13031291
),
13041292

1305-
TP_printk("peer=[%s]:%s r_xprt=%p: %u reqs",
1306-
__get_str(addr), __get_str(port),
1307-
__entry->r_xprt, __entry->reqs
1293+
TP_printk("peer=[%s]:%s %u reqs",
1294+
__get_str(addr), __get_str(port), __entry->reqs
13081295
)
13091296
);
13101297

0 commit comments

Comments
 (0)