Skip to content

Commit 867de40

Browse files
Mikulas Patockasnitm
authored andcommitted
dm writecache: write at least 4k when committing
SSDs perform badly with sub-4k writes (because they perfrorm read-modify-write internally), so make sure writecache writes at least 4k when committing. Fixes: 991bd8d ("dm writecache: commit just one block, not a full page") Signed-off-by: Mikulas Patocka <[email protected]> Signed-off-by: Mike Snitzer <[email protected]>
1 parent ee55b92 commit 867de40

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

drivers/md/dm-writecache.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,11 @@ static void ssd_commit_superblock(struct dm_writecache *wc)
532532

533533
region.bdev = wc->ssd_dev->bdev;
534534
region.sector = 0;
535-
region.count = wc->block_size >> SECTOR_SHIFT;
535+
region.count = max(4096U, wc->block_size) >> SECTOR_SHIFT;
536+
537+
if (unlikely(region.sector + region.count > wc->metadata_sectors))
538+
region.count = wc->metadata_sectors - region.sector;
539+
536540
region.sector += wc->start_sector;
537541

538542
req.bi_op = REQ_OP_WRITE;

0 commit comments

Comments
 (0)