Skip to content

Commit 884af72

Browse files
SamuelZOUlinusw
authored andcommitted
pinctrl: mcp23s08: Fix missing unlock on error in mcp23s08_irq()
Add the missing unlock before return from function mcp23s08_irq() in the error handling case. v1-->v2: remove the "return IRQ_HANDLED" line Fixes: 897120d ("pinctrl: mcp23s08: fix race condition in irq handler") Reported-by: Hulk Robot <[email protected]> Signed-off-by: Zou Wei <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent 0c68387 commit 884af72

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/pinctrl/pinctrl-mcp23s08.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ static irqreturn_t mcp23s08_irq(int irq, void *data)
353353

354354
if (intf == 0) {
355355
/* There is no interrupt pending */
356-
return IRQ_HANDLED;
356+
goto unlock;
357357
}
358358

359359
if (mcp_read(mcp, MCP_INTCAP, &intcap))

0 commit comments

Comments
 (0)