Skip to content

Commit 89d74b3

Browse files
tititiou36storulf
authored andcommitted
memstick: switch from 'pci_' to 'dma_' API
The wrappers in include/linux/pci-dma-compat.h should go away. The patch has been generated with the coccinelle script below. It has been compile tested. No memory allocation in involved in this patch, so no GFP_ tweak is needed. @@ @@ - PCI_DMA_BIDIRECTIONAL + DMA_BIDIRECTIONAL @@ @@ - PCI_DMA_TODEVICE + DMA_TO_DEVICE @@ @@ - PCI_DMA_FROMDEVICE + DMA_FROM_DEVICE @@ @@ - PCI_DMA_NONE + DMA_NONE @@ expression e1, e2, e3; @@ - pci_alloc_consistent(e1, e2, e3) + dma_alloc_coherent(&e1->dev, e2, e3, GFP_) @@ expression e1, e2, e3; @@ - pci_zalloc_consistent(e1, e2, e3) + dma_alloc_coherent(&e1->dev, e2, e3, GFP_) @@ expression e1, e2, e3, e4; @@ - pci_free_consistent(e1, e2, e3, e4) + dma_free_coherent(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_map_single(e1, e2, e3, e4) + dma_map_single(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_unmap_single(e1, e2, e3, e4) + dma_unmap_single(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4, e5; @@ - pci_map_page(e1, e2, e3, e4, e5) + dma_map_page(&e1->dev, e2, e3, e4, e5) @@ expression e1, e2, e3, e4; @@ - pci_unmap_page(e1, e2, e3, e4) + dma_unmap_page(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_map_sg(e1, e2, e3, e4) + dma_map_sg(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_unmap_sg(e1, e2, e3, e4) + dma_unmap_sg(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_dma_sync_single_for_cpu(e1, e2, e3, e4) + dma_sync_single_for_cpu(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_dma_sync_single_for_device(e1, e2, e3, e4) + dma_sync_single_for_device(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_dma_sync_sg_for_cpu(e1, e2, e3, e4) + dma_sync_sg_for_cpu(&e1->dev, e2, e3, e4) @@ expression e1, e2, e3, e4; @@ - pci_dma_sync_sg_for_device(e1, e2, e3, e4) + dma_sync_sg_for_device(&e1->dev, e2, e3, e4) @@ expression e1, e2; @@ - pci_dma_mapping_error(e1, e2) + dma_mapping_error(&e1->dev, e2) @@ expression e1, e2; @@ - pci_set_dma_mask(e1, e2) + dma_set_mask(&e1->dev, e2) @@ expression e1, e2; @@ - pci_set_consistent_dma_mask(e1, e2) + dma_set_coherent_mask(&e1->dev, e2) Signed-off-by: Christophe JAILLET <[email protected]> Link: https://lore.kernel.org/r/f6fe24f2372c8c627a08ace7187bfe60d35788b6.1629580314.git.christophe.jaillet@wanadoo.fr Signed-off-by: Ulf Hansson <[email protected]>
1 parent 2b50c81 commit 89d74b3

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

drivers/memstick/host/r592.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ static int r592_transfer_fifo_dma(struct r592_device *dev)
293293

294294
/* TODO: hidden assumption about nenth beeing always 1 */
295295
sg_count = dma_map_sg(&dev->pci_dev->dev, &dev->req->sg, 1, is_write ?
296-
PCI_DMA_TODEVICE : PCI_DMA_FROMDEVICE);
296+
DMA_TO_DEVICE : DMA_FROM_DEVICE);
297297

298298
if (sg_count != 1 || sg_dma_len(&dev->req->sg) < R592_LFIFO_SIZE) {
299299
message("problem in dma_map_sg");
@@ -310,8 +310,7 @@ static int r592_transfer_fifo_dma(struct r592_device *dev)
310310
}
311311

312312
dma_unmap_sg(&dev->pci_dev->dev, &dev->req->sg, 1, is_write ?
313-
PCI_DMA_TODEVICE : PCI_DMA_FROMDEVICE);
314-
313+
DMA_TO_DEVICE : DMA_FROM_DEVICE);
315314

316315
return dev->dma_error;
317316
}

drivers/memstick/host/tifm_ms.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -279,8 +279,8 @@ static int tifm_ms_issue_cmd(struct tifm_ms *host)
279279
if (host->use_dma) {
280280
if (1 != tifm_map_sg(sock, &host->req->sg, 1,
281281
host->req->data_dir == READ
282-
? PCI_DMA_FROMDEVICE
283-
: PCI_DMA_TODEVICE)) {
282+
? DMA_FROM_DEVICE
283+
: DMA_TO_DEVICE)) {
284284
host->req->error = -ENOMEM;
285285
return host->req->error;
286286
}
@@ -350,8 +350,8 @@ static void tifm_ms_complete_cmd(struct tifm_ms *host)
350350
if (host->use_dma) {
351351
tifm_unmap_sg(sock, &host->req->sg, 1,
352352
host->req->data_dir == READ
353-
? PCI_DMA_FROMDEVICE
354-
: PCI_DMA_TODEVICE);
353+
? DMA_FROM_DEVICE
354+
: DMA_TO_DEVICE);
355355
}
356356

357357
writel((~TIFM_CTRL_LED) & readl(sock->addr + SOCK_CONTROL),
@@ -607,8 +607,8 @@ static void tifm_ms_remove(struct tifm_dev *sock)
607607
if (host->use_dma)
608608
tifm_unmap_sg(sock, &host->req->sg, 1,
609609
host->req->data_dir == READ
610-
? PCI_DMA_TODEVICE
611-
: PCI_DMA_FROMDEVICE);
610+
? DMA_TO_DEVICE
611+
: DMA_FROM_DEVICE);
612612
host->req->error = -ETIME;
613613

614614
do {

0 commit comments

Comments
 (0)