Skip to content

Commit 8b9cc17

Browse files
committed
Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi
Pull more SCSI updates from James Bottomley: "This is a set of minor fixes and clean ups in the core and various drivers. The only core change in behaviour is the I/O retry for spinup notify, but that shouldn't impact anything other than the failing case" * tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi: (23 commits) scsi: virtio_scsi: Add validation for residual bytes from response scsi: ipr: System crashes when seeing type 20 error scsi: core: Retry I/O for Notify (Enable Spinup) Required error scsi: mpi3mr: Fix warnings reported by smatch scsi: qedf: Add check to synchronize abort and flush scsi: MAINTAINERS: Add mpi3mr driver maintainers scsi: libfc: Fix array index out of bound exception scsi: mvsas: Use DEVICE_ATTR_RO()/RW() macro scsi: megaraid_mbox: Use DEVICE_ATTR_ADMIN_RO() macro scsi: qedf: Use DEVICE_ATTR_RO() macro scsi: qedi: Use DEVICE_ATTR_RO() macro scsi: message: mptfc: Switch from pci_ to dma_ API scsi: be2iscsi: Fix some missing space in some messages scsi: be2iscsi: Fix an error handling path in beiscsi_dev_probe() scsi: ufs: Fix build warning without CONFIG_PM scsi: bnx2fc: Remove meaningless bnx2fc_abts_cleanup() return value assignment scsi: qla2xxx: Add heartbeat check scsi: virtio_scsi: Do not overwrite SCSI status scsi: libsas: Add LUN number check in .slave_alloc callback scsi: core: Inline scsi_mq_alloc_queue() ...
2 parents b1412bd + 5f638e5 commit 8b9cc17

36 files changed

+287
-162
lines changed

MAINTAINERS

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3781,6 +3781,17 @@ S: Supported
37813781
F: Documentation/devicetree/bindings/gpio/brcm,kona-gpio.txt
37823782
F: drivers/gpio/gpio-bcm-kona.c
37833783

3784+
BROADCOM MPI3 STORAGE CONTROLLER DRIVER
3785+
M: Sathya Prakash Veerichetty <[email protected]>
3786+
M: Kashyap Desai <[email protected]>
3787+
M: Sumit Saxena <[email protected]>
3788+
M: Sreekanth Reddy <[email protected]>
3789+
3790+
3791+
S: Supported
3792+
W: https://www.broadcom.com/support/storage
3793+
F: drivers/scsi/mpi3mr/
3794+
37843795
BROADCOM NETXTREME-E ROCE DRIVER
37853796
M: Selvin Xavier <[email protected]>
37863797
M: Naresh Kumar PBS <[email protected]>

drivers/message/fusion/mptfc.c

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,8 @@ mptfc_GetFcDevPage0(MPT_ADAPTER *ioc, int ioc_port,
331331
break;
332332

333333
data_sz = hdr.PageLength * 4;
334-
ppage0_alloc = pci_alloc_consistent(ioc->pcidev, data_sz,
335-
&page0_dma);
334+
ppage0_alloc = dma_alloc_coherent(&ioc->pcidev->dev, data_sz,
335+
&page0_dma, GFP_KERNEL);
336336
rc = -ENOMEM;
337337
if (!ppage0_alloc)
338338
break;
@@ -367,8 +367,8 @@ mptfc_GetFcDevPage0(MPT_ADAPTER *ioc, int ioc_port,
367367
*p_p0 = *ppage0_alloc; /* save data */
368368
*p_pp0++ = p_p0++; /* save addr */
369369
}
370-
pci_free_consistent(ioc->pcidev, data_sz,
371-
(u8 *) ppage0_alloc, page0_dma);
370+
dma_free_coherent(&ioc->pcidev->dev, data_sz,
371+
ppage0_alloc, page0_dma);
372372
if (rc != 0)
373373
break;
374374

@@ -763,7 +763,8 @@ mptfc_GetFcPortPage0(MPT_ADAPTER *ioc, int portnum)
763763

764764
data_sz = hdr.PageLength * 4;
765765
rc = -ENOMEM;
766-
ppage0_alloc = pci_alloc_consistent(ioc->pcidev, data_sz, &page0_dma);
766+
ppage0_alloc = dma_alloc_coherent(&ioc->pcidev->dev, data_sz,
767+
&page0_dma, GFP_KERNEL);
767768
if (ppage0_alloc) {
768769

769770
try_again:
@@ -817,7 +818,8 @@ mptfc_GetFcPortPage0(MPT_ADAPTER *ioc, int portnum)
817818
mptfc_display_port_link_speed(ioc, portnum, pp0dest);
818819
}
819820

820-
pci_free_consistent(ioc->pcidev, data_sz, (u8 *) ppage0_alloc, page0_dma);
821+
dma_free_coherent(&ioc->pcidev->dev, data_sz, ppage0_alloc,
822+
page0_dma);
821823
}
822824

823825
return rc;
@@ -904,9 +906,8 @@ mptfc_GetFcPortPage1(MPT_ADAPTER *ioc, int portnum)
904906
if (data_sz < sizeof(FCPortPage1_t))
905907
data_sz = sizeof(FCPortPage1_t);
906908

907-
page1_alloc = pci_alloc_consistent(ioc->pcidev,
908-
data_sz,
909-
&page1_dma);
909+
page1_alloc = dma_alloc_coherent(&ioc->pcidev->dev, data_sz,
910+
&page1_dma, GFP_KERNEL);
910911
if (!page1_alloc)
911912
return -ENOMEM;
912913
}
@@ -916,8 +917,8 @@ mptfc_GetFcPortPage1(MPT_ADAPTER *ioc, int portnum)
916917
data_sz = ioc->fc_data.fc_port_page1[portnum].pg_sz;
917918
if (hdr.PageLength * 4 > data_sz) {
918919
ioc->fc_data.fc_port_page1[portnum].data = NULL;
919-
pci_free_consistent(ioc->pcidev, data_sz, (u8 *)
920-
page1_alloc, page1_dma);
920+
dma_free_coherent(&ioc->pcidev->dev, data_sz,
921+
page1_alloc, page1_dma);
921922
goto start_over;
922923
}
923924
}
@@ -932,8 +933,8 @@ mptfc_GetFcPortPage1(MPT_ADAPTER *ioc, int portnum)
932933
}
933934
else {
934935
ioc->fc_data.fc_port_page1[portnum].data = NULL;
935-
pci_free_consistent(ioc->pcidev, data_sz, (u8 *)
936-
page1_alloc, page1_dma);
936+
dma_free_coherent(&ioc->pcidev->dev, data_sz, page1_alloc,
937+
page1_dma);
937938
}
938939

939940
return rc;
@@ -1514,10 +1515,10 @@ static void mptfc_remove(struct pci_dev *pdev)
15141515

15151516
for (ii=0; ii<ioc->facts.NumberOfPorts; ii++) {
15161517
if (ioc->fc_data.fc_port_page1[ii].data) {
1517-
pci_free_consistent(ioc->pcidev,
1518-
ioc->fc_data.fc_port_page1[ii].pg_sz,
1519-
(u8 *) ioc->fc_data.fc_port_page1[ii].data,
1520-
ioc->fc_data.fc_port_page1[ii].dma);
1518+
dma_free_coherent(&ioc->pcidev->dev,
1519+
ioc->fc_data.fc_port_page1[ii].pg_sz,
1520+
ioc->fc_data.fc_port_page1[ii].data,
1521+
ioc->fc_data.fc_port_page1[ii].dma);
15211522
ioc->fc_data.fc_port_page1[ii].data = NULL;
15221523
}
15231524
}

drivers/scsi/aic7xxx/aic7xxx_core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ ahc_inq(struct ahc_softc *ahc, u_int port)
493493
return ((ahc_inb(ahc, port))
494494
| (ahc_inb(ahc, port+1) << 8)
495495
| (ahc_inb(ahc, port+2) << 16)
496-
| (ahc_inb(ahc, port+3) << 24)
496+
| (((uint64_t)ahc_inb(ahc, port+3)) << 24)
497497
| (((uint64_t)ahc_inb(ahc, port+4)) << 32)
498498
| (((uint64_t)ahc_inb(ahc, port+5)) << 40)
499499
| (((uint64_t)ahc_inb(ahc, port+6)) << 48)

drivers/scsi/aic94xx/aic94xx_init.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ static struct scsi_host_template aic94xx_sht = {
5353
.max_sectors = SCSI_DEFAULT_MAX_SECTORS,
5454
.eh_device_reset_handler = sas_eh_device_reset_handler,
5555
.eh_target_reset_handler = sas_eh_target_reset_handler,
56+
.slave_alloc = sas_slave_alloc,
5657
.target_destroy = sas_target_destroy,
5758
.ioctl = sas_ioctl,
5859
#ifdef CONFIG_COMPAT

0 commit comments

Comments
 (0)