Skip to content

Commit 8c08652

Browse files
ranj063broonie
authored andcommitted
ASoC: SOF: Intel: hda: don't send DAI_CONFIG IPC for older firmware
BE hw_params op was recently added for SSP type DAIs. But sending the DAI_CONFIG IPC during hw_params is not supported with older firmware. So add an ABI check to avoid sending the IPC if the firmware ABI is older than 3.18. Fixes: e12be9f ('ASoC: SOF: Intel: HDA: add hw params callback for SSP DAIs') Tested-by: Yong Zhi <[email protected]> Reviewed-by: Kai Vehmanen <[email protected]> Signed-off-by: Ranjani Sridharan <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent cdf112d commit 8c08652

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

sound/soc/sof/intel/hda-dai.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -421,11 +421,16 @@ static int ssp_dai_hw_params(struct snd_pcm_substream *substream,
421421
struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
422422
struct snd_soc_component *component = snd_soc_rtdcom_lookup(rtd, SOF_AUDIO_PCM_DRV_NAME);
423423
struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(component);
424+
struct sof_ipc_fw_version *v = &sdev->fw_ready.version;
424425
struct sof_ipc_dai_config *config;
425426
struct snd_sof_dai *sof_dai;
426427
struct sof_ipc_reply reply;
427428
int ret;
428429

430+
/* DAI_CONFIG IPC during hw_params is not supported in older firmware */
431+
if (v->abi_version < SOF_ABI_VER(3, 18, 0))
432+
return 0;
433+
429434
list_for_each_entry(sof_dai, &sdev->dai_list, list) {
430435
if (!sof_dai->cpu_dai_name || !sof_dai->dai_config)
431436
continue;

0 commit comments

Comments
 (0)