Skip to content

Commit 8f922e4

Browse files
tursulindanvet
authored andcommitted
drm/i915: Restrict sentinel requests further
Disallow sentinel requests follow previous sentinels to make request cancellation work better when faced with a chain of requests which have all been marked as in error. Because in cases where we end up with a stream of cancelled requests we want to turn off request coalescing so they each will get individually skipped by the execlists_schedule_in (which is called per ELSP port, not per request). Signed-off-by: Tvrtko Ursulin <[email protected]> Reviewed-by: Matthew Auld <[email protected]> [danvet: Fix typo in the commit message that Matthew spotted.] Signed-off-by: Daniel Vetter <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 38b237e commit 8f922e4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/i915/gt/intel_execlists_submission.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -953,7 +953,7 @@ static bool can_merge_rq(const struct i915_request *prev,
953953
if (__i915_request_is_complete(next))
954954
return true;
955955

956-
if (unlikely((i915_request_flags(prev) ^ i915_request_flags(next)) &
956+
if (unlikely((i915_request_flags(prev) | i915_request_flags(next)) &
957957
(BIT(I915_FENCE_FLAG_NOPREEMPT) |
958958
BIT(I915_FENCE_FLAG_SENTINEL))))
959959
return false;

0 commit comments

Comments
 (0)