Skip to content

Commit 93103f6

Browse files
jayxurockchiplinusw
authored andcommitted
gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
There has spin lock for irq set type already, so drop irq_gc_lock and irq_gc_unlock. Reviewed-by: Heiko Stuebner <[email protected]> Signed-off-by: Jianqun Xu <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Linus Walleij <[email protected]>
1 parent 3bcbd1a commit 93103f6

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/gpio/gpio-rockchip.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -406,7 +406,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type)
406406
irq_set_handler_locked(d, handle_level_irq);
407407

408408
raw_spin_lock_irqsave(&bank->slock, flags);
409-
irq_gc_lock(gc);
410409

411410
level = rockchip_gpio_readl(bank, bank->gpio_regs->int_type);
412411
polarity = rockchip_gpio_readl(bank, bank->gpio_regs->int_polarity);
@@ -461,7 +460,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type)
461460
rockchip_gpio_writel(bank, level, bank->gpio_regs->int_type);
462461
rockchip_gpio_writel(bank, polarity, bank->gpio_regs->int_polarity);
463462
out:
464-
irq_gc_unlock(gc);
465463
raw_spin_unlock_irqrestore(&bank->slock, flags);
466464

467465
return ret;

0 commit comments

Comments
 (0)