platform/x86: amd-pmc: Fix missing unlock on error in amd_pmc_send_cmd()

Yang Yingliang · jwrdegoede · commit 95edbbf78c3b · 2021-07-15T10:27:20.000+02:00
Add the missing unlock before return from function amd_pmc_send_cmd() in the error handling case. Fixes: 95e1b60 ("platform/x86: amd-pmc: Fix command completion code") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Link: https://lore.kernel.org/r/20210715074327.1966083-1-yangyingliang@huawei.com Signed-off-by: Hans de Goede <hdegoede@redhat.com>
diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c
@@ -275,7 +275,7 @@ static int amd_pmc_send_cmd(struct amd_pmc_dev *dev, bool set, u32 *data, u8 msg
 				PMC_MSG_DELAY_MIN_US * RESPONSE_REGISTER_LOOP_MAX);
 	if (rc) {
 		dev_err(dev->dev, "failed to talk to SMU\n");
-		return rc;
+		goto out_unlock;
 	}
 
 	/* Write zero to response register */

Original file line number	Diff line number	Diff line change
`@@ -275,7 +275,7 @@ static int amd_pmc_send_cmd(struct amd_pmc_dev dev, bool set, u32 data, u8 msg`
`275`	`275`	`PMC_MSG_DELAY_MIN_US * RESPONSE_REGISTER_LOOP_MAX);`
`276`	`276`	`if (rc) {`
`277`	`277`	`dev_err(dev->dev, "failed to talk to SMU\n");`
`278`		`- return rc;`
	`278`	`+ goto out_unlock;`
`279`	`279`	`}`
`280`	`280`
`281`	`281`	`/* Write zero to response register */`