Skip to content

Commit 97e0341

Browse files
Adrian Huangrafaeljw
authored andcommitted
ACPI: tables: FPDT: Do not print FW_BUG message if record types are reserved
In ACPI 6.4 spec, record types "0x0002-0xffff" of FPDT Performance Record Types [1] and record types "0x0003-0xffff" of Runtime Performance Record Types [2] are reserved. Users might be confused with the FW_BUG message, and they think this is the FW issue. Here is the example in a Lenovo box: ACPI: FPDT 0x00000000A820A000 000044 (v01 LENOVO THINKSYS 00000100 01000013) ACPI: Reserving FPDT table memory at [mem 0xa820a000-0xa820a043] ACPI FPDT: [Firmware Bug]: Invalid record 4113 found So, remove the FW_BUG message to avoid confusion since those types are reserved in ACPI 6.4 spec. [1] https://uefi.org/specs/ACPI/6.4/05_ACPI_Software_Programming_Model/ACPI_Software_Programming_Model.html#fpdt-performance-record-types-table [2] https://uefi.org/specs/ACPI/6.4/05_ACPI_Software_Programming_Model/ACPI_Software_Programming_Model.html#runtime-performance-record-types-table Signed-off-by: Adrian Huang <[email protected]> Acked-by: Zhang Rui <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 2aaea6a commit 97e0341

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

drivers/acpi/acpi_fpdt.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,8 @@ static int fpdt_process_subtable(u64 address, u32 subtable_type)
220220
break;
221221

222222
default:
223-
pr_err(FW_BUG "Invalid record %d found.\n", record_header->type);
224-
return -EINVAL;
223+
/* Other types are reserved in ACPI 6.4 spec. */
224+
break;
225225
}
226226
}
227227
return 0;
@@ -254,8 +254,7 @@ static int __init acpi_init_fpdt(void)
254254
subtable->type);
255255
break;
256256
default:
257-
pr_info(FW_BUG "Invalid subtable type %d found.\n",
258-
subtable->type);
257+
/* Other types are reserved in ACPI 6.4 spec. */
259258
break;
260259
}
261260
offset += sizeof(*subtable);

0 commit comments

Comments
 (0)